Skip to content

Commit 9ebe5ef

Browse files
committed
fix: address PR review comments
- Remove unused `digest` workspace dependency - Remove non-canonical `authors` field from jolt-field - Merge `arkworks` feature into `bn254` (single feature)
1 parent c56a129 commit 9ebe5ef

4 files changed

Lines changed: 563 additions & 15 deletions

File tree

.github/workflows/fuzz-crates.yml

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,39 @@
1-
name: Fuzz modular crates
1+
name: Fuzz jolt-field
22

33
on:
44
push:
55
branches: [main]
66
paths:
7-
- "crates/**"
7+
- "crates/jolt-field/**"
88
pull_request:
99
branches: [main]
1010
paths:
11-
- "crates/**"
11+
- "crates/jolt-field/**"
1212

1313
env:
1414
CARGO_TERM_COLOR: always
1515
FUZZ_DURATION: 60
1616

1717
concurrency:
18-
group: fuzz-crates-${{ github.head_ref || github.ref }}
18+
group: fuzz-jolt-field-${{ github.head_ref || github.ref }}
1919
cancel-in-progress: true
2020

2121
jobs:
2222
fuzz:
2323
runs-on: ubuntu-latest
24-
name: Fuzz targets
25-
strategy:
26-
fail-fast: false
27-
matrix:
28-
target: [from_bytes, field_arith, wide_accumulator_fmadd, wide_accumulator_merge]
24+
name: Fuzz jolt-field
2925
steps:
3026
- uses: actions/checkout@v6
3127
- uses: actions-rust-lang/setup-rust-toolchain@v1
3228
with:
3329
toolchain: nightly
3430
- name: Install cargo-fuzz
3531
run: cargo install cargo-fuzz --locked
36-
- name: Run ${{ matrix.target }}
32+
- name: Fuzz all targets
3733
working-directory: crates/jolt-field
38-
run: cargo +nightly fuzz run ${{ matrix.target }} -- -max_total_time=${{ env.FUZZ_DURATION }}
34+
run: |
35+
set -euo pipefail
36+
for target in from_bytes field_arith wide_accumulator_fmadd wide_accumulator_merge; do
37+
echo "--- Fuzzing $target for ${FUZZ_DURATION}s ---"
38+
cargo +nightly fuzz run "$target" -- -max_total_time=$FUZZ_DURATION
39+
done

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,6 @@ sha3 = "0.10.8"
235235
blake2 = "0.10"
236236
blake3 = { version = "1.5.0" }
237237
light-poseidon = "0.4"
238-
digest = "0.10"
239238
jolt-optimizations = { git = "https://github.com/a16z/arkworks-algebra", branch = "dev/twist-shout" }
240239
dory = { package = "dory-pcs", version = "0.3.0", features = ["backends", "cache", "disk-persistence"] }
241240

crates/jolt-field/Cargo.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
[package]
22
name = "jolt-field"
33
version = "0.1.0"
4-
authors = ["Jolt Contributors"]
54
edition = "2021"
65
license = "MIT OR Apache-2.0"
76
description = "Field abstractions for the Jolt zkVM"
@@ -24,8 +23,7 @@ rand_core = { workspace = true }
2423

2524
[features]
2625
default = ["bn254"]
27-
arkworks = ["dep:ark-ff", "dep:ark-serialize"]
28-
bn254 = ["dep:ark-bn254", "arkworks"]
26+
bn254 = ["dep:ark-ff", "dep:ark-serialize", "dep:ark-bn254"]
2927
allocative = ["dep:allocative"]
3028

3129
[dev-dependencies]

0 commit comments

Comments
 (0)