Skip to content

counsel-git-grep-switch-cmd does not set enable-recursive-minibuffers #2720

Description

@brownts

Most/all? counsel commands which can be launched from the minibuffer appear to locally set enable-recursive-minibuffers to avoid a "Command attempted to use minibuffer while in minibuffer" error (e.g., counsel-cd). However, it appears that counsel-git-grep-switch-cmd does not locally set this variable. Thus, when the Emacs configuration does not enable recursive minibuffers, this will prevent the custom git-grep command functionality from working successfully.

Steps to reproduce:

  1. Start Emacs via the repository make plain command
  2. Clear enable-recursive-minibuffers: M-: (setq enable-recursive-minibuffers nil)
  3. Open ivy.el in buffer: C-x C-f ~/git/swiper/ivy.el
  4. Start a git-grep search: C-c j
  5. Attempt to switch git command: C-c C-m

Error "Command attempted to use minibuffer while in minibuffer" is displayed.

Metadata

Metadata

Assignees

Labels

enhancementSuggestion to improve or extend existing behavior

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions