[sestring] Too many arguments for macro

[WorkingRobot]

The following SeStrings are unable to be parsed by ironworks due to an Error::TooManyArguments error:

• Addon#15955:

[Text(TextPayload([67, 111, 109, 112, 108, 101, 116, 101, 32, 102, 108, 111, 111, 114, 32])), Macro(MacroPayload(Num, [232, 4])), Text(TextPayload([32, 111, 102, 32])), Macro(MacroPayload(String, [234, 2])), Text(TextPayload([46, 32])), Macro(MacroPayload(Sheet, [255, 6, 65, 100, 100, 111, 110, 242, 62, 85, 1, 232, 5, 232, 4]))]

• Addon#15958:

[Macro(MacroPayload(Sheet, [255, 6, 65, 100, 100, 111, 110, 242, 62, 83, 1, 255, 96, 2, 40, 92, 255, 10, 80, 108, 97, 99, 101, 78, 97, 109, 101, 255, 78, 2, 40, 74, 255, 14, 84, 101, 114, 114, 105, 116, 111, 114, 121, 84, 121, 112, 101, 255, 56, 2, 40, 52, 255, 23, 67, 111, 110, 116, 101, 110, 116, 70, 105, 110, 100, 101, 114, 67, 111, 110, 100, 105, 116, 105, 111, 110, 255, 25, 2, 40, 21, 255, 16, 73, 110, 115, 116, 97, 110, 99, 101, 67, 111, 110, 116, 101, 110, 116, 232, 6, 9, 3, 2, 3, 6, 3, 1, 3, 232, 15, 232, 13, 232, 17]))]

I'll see if I can try to fix it and identify more rows.

[WorkingRobot]

Found a fix using this patch:

diff --git a/ironworks/src/sestring/format/excel.rs b/ironworks/src/sestring/format/excel.rs
index fc514f8..2a81911 100644
--- a/ironworks/src/sestring/format/excel.rs
+++ b/ironworks/src/sestring/format/excel.rs
@@ -4,9 +4,17 @@ use super::{argument::Arguments, format::State, value::Value};
 
 // TODO: Implement these.
 
-pub fn sheet<'a>(arguments: impl Arguments<'a>, state: &mut State) -> Result<()> {
-	let (_sheet, _row, _column, _parameter) =
-		arguments.exhaustive::<(String, u32, Option<u32>, Option<u32>)>(state)?;
+pub fn sheet<'a>(mut arguments: impl Arguments<'a>, state: &mut State) -> Result<()> {
+	let (_sheet, _row, _column) = arguments.evaluate::<(String, u32, Option<u32>)>(state)?;
+
+	let _parameters = arguments.collect::<Result<Vec<_>>>()?;
 	Ok(())
 }

[ackwell]

ack on this; sorry, irl been throwing hands last month and a bit.

don't have tools on hand right now; to confirm i'm following;

• first example has two parameters, [lnum4, lnum3]
• second example has four parameters, [SHEETDATA, lnum14, lnum12, lnum16]

which suggests that the sheet macro accepts an arbitrary parameter list to pass on to the inner evaluation?

if that's the case, patch makes sense. i think i saw you include it in the pr you've got open - i probably won't have time to read through that in the immediate term, but if you throw the patch up as a separate pr i can merge it.