Skip to content

Conversation

@neoncube2
Copy link
Contributor

Fixes #829

@marijnh
Copy link
Member

marijnh commented Nov 13, 2025

Doing the check for when baseVisitor is undefined on every single node, instead of once at the start of a walk, doesn't necessarily seem like an improvement. Could you revert that part? Also, I think the error message would be clearer if it said `No walker function defined for node type ${type}`.

@neoncube2
Copy link
Contributor Author

neoncube2 commented Nov 14, 2025

Oh, whoops, I didn't realize that check was in a loop XD

Fixed, and the error message has also been changed :)

@marijnh marijnh merged commit 356ed94 into acornjs:master Nov 14, 2025
@marijnh
Copy link
Member

marijnh commented Nov 14, 2025

Thank you!

marijnh added a commit that referenced this pull request Nov 14, 2025
@neoncube2
Copy link
Contributor Author

No problem, and thanks for the review! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[acorn-walk]: baseVisitor[type] is not a function when walking with a plugin

2 participants