Merge remote-tracking branch 'upstream/main' into releases

Author: andiwand

.github/actions/dependencies/action.yml

@@ -26,6 +26,9 @@ inputs:
     description: 'Whether to do a full dependency installation including Geant4 datasets and Python packages'
     required: false
     default: 'false'
+  env_file:
+    description: 'Where to generate the environment file'
+    required: true
 
 
 runs:
@@ -87,7 +90,7 @@ runs:
         SPACK_REPO_VERSION: ${{ inputs.spack_repo_version }}
         DEPENDENCY_TAG: ${{ inputs.DEPENDENCY_TAG }}
       run: |
-        args=""
+        args="-e ${{ inputs.env_file }}"
         if [ "${{ inputs.full_install }}" == "true" ]; then
           echo "Full install"
           args="${args} -f"

.github/workflows/analysis.yml

@@ -39,6 +39,7 @@ jobs:
         with:
           compiler: g++
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          env_file: .env
 
       - name: Save PR metadata
         if: github.event_name == 'pull_request'
@@ -71,6 +72,7 @@ jobs:
       - name: Configure
         run: >
           ccache -z &&
+          CI/dependencies/run.sh .env
           cmake -B build -S . --preset=github-ci-coverage
       - name: Build
         run: cmake --build build
@@ -85,15 +87,30 @@ jobs:
           && find build -name *.o -delete
           && du -sh build
       - name: Coverage
-        run: >
-          pip3 install gcovr==7.2
-          && cd build
-          && /usr/bin/python3 ../CI/test_coverage.py
+        run: |
+          uv run --no-project CI/test_coverage.py build --filter
 
       - uses: actions/upload-artifact@v6
+        if: always()
         with:
           name: coverage-build
-          path: build
+          path: |
+            build/compile_commands.json
+            build/coverage/cov.xml
+
+      - uses: actions/upload-artifact@v6
+        if: always()
+        id: artifact-upload-step
+        with:
+          name: coverage-html
+          path: build/coverage/html
+
+      - name: Coverage display
+        run: |
+          base_link='https://acts-herald.app.cern.ch/view/${{ github.repository }}/${{ steps.artifact-upload-step.outputs.artifact-id }}'
+          link="$base_link/index.html"
+          echo "🛡️ Code coverage available at: $link"
+          echo "**🛡️ Code coverage available [here]($link)**" >> $GITHUB_STEP_SUMMARY
 
   clang_tidy:
     runs-on: ubuntu-latest
@@ -111,7 +128,7 @@ jobs:
         if: github.event_name == 'pull_request'
         run: git fetch origin "${{ github.base_ref }}"
 
-      - uses: astral-sh/setup-uv@v5
+      - uses: astral-sh/setup-uv@v7
 
       - name: Install clang-tidy
         run: |
@@ -125,9 +142,12 @@ jobs:
         with:
           compiler: clang++
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          env_file: .env
 
       - name: Configure
         run: >
+          ccache -z &&
+          CI/dependencies/run.sh .env
           cmake -B build -S .
           --preset=gitlab-ci-clangtidy
 
@@ -157,61 +177,3 @@ jobs:
         run: >
           uv run CI/clang_tidy/run_clang_tidy_pr.py
           annotate fixes.yml
-
-  build_performance:
-    runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/ubuntu2404:83
-    if: github.ref == 'refs/heads/main'
-    steps:
-      - uses: actions/checkout@v6
-
-      - name: Install dependencies
-        uses: ./.github/actions/dependencies
-        with:
-          compiler: g++
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Install dependencies
-        run: pip3 install cmakeperf==0.6.1
-      - name: Configure
-        run: >
-          cmake -B build -S .
-          --preset=github-ci
-          -DCMAKE_BUILD_TYPE=RelWithDebInfo
-          -DCMAKE_CXX_FLAGS="-Werror"
-          -DPython_EXECUTABLE=$(which python3)
-          -DACTS_BUILD_ODD=OFF
-      - name: Measure
-        run: cmakeperf collect build/compile_commands.json -o perf.csv
-      - name: Results
-        run: cmakeperf print perf.csv
-      - uses: actions/upload-artifact@v6
-        with:
-          name: cmakeperf
-          path: perf.csv
-
-  # metric_tracking:
-  #   runs-on: ubuntu-latest
-  #   needs: build_performance
-  #   if: github.ref == 'refs/heads/main'
-  #   steps:
-  #     - uses: actions/checkout@v6
-  #     - name: Install dependencies
-  #       run: pip3 install git+https://github.com/paulgessinger/headwind.git@eeeaa80
-  #     - uses: actions/download-artifact@v4
-  #       with:
-  #         name: cmakeperf
-  #     - name: Run collection
-  #       env:
-  #         SSH_AUTH_SOCK: /tmp/ssh_agent.sock
-  #       run: |
-  #         ssh-agent -a $SSH_AUTH_SOCK > /dev/null
-  #         ssh-add - <<< "${{ secrets.METRIC_DEPLOY_SSH_KEY }}"
-  #         git config --global user.email "action@github.com"
-  #         git config --global user.name "GitHub Action"
-  #         git clone git@github.com:acts-project/metrics.git
-  #         hdw collect CI/headwind.yml --commit $(git log --pretty=format:'%H' -1)
-  #         cd metrics
-  #         git add -A
-  #         git commit -m"update metrics"
-  #         git push

.github/workflows/builds.yml

@@ -39,6 +39,7 @@ jobs:
         with:
           compiler: g++
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          env_file: .env
 
       - name: Restore ccache
         id: ccache-restore
@@ -52,6 +53,7 @@ jobs:
       - name: Configure
         run: >
           ccache -z &&
+          CI/dependencies/run.sh .env
           cmake -B build -S .
           --preset=github-ci
           -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}"
@@ -85,7 +87,10 @@ jobs:
 
       - name: Python sanity check after install
         shell: bash
-        run: source install/python/setup.sh && python -c "import acts; v = acts.Vector3(1,2,3)"
+        run: >
+          source .env &&
+          source install/python/setup.sh &&
+          python -c "import acts; v = acts.Vector3(1,2,3)"
 
       - name: Package build
         run: tar czf build.tar.gz -C build --exclude "*.o" --exclude "bin/ActsUnitTest*" --exclude "bin/ActsIntegrationTest*" .
@@ -97,6 +102,7 @@ jobs:
 
       - name: Downstream configure
         run: >
+          CI/dependencies/run.sh .env
           cmake -B build-downstream -S Tests/DownstreamProject
           -GNinja
           -DCMAKE_BUILD_TYPE=Release
@@ -126,6 +132,7 @@ jobs:
         with:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           full_install: true
+          env_file: .env
 
       - uses: actions/download-artifact@v7
         with:
@@ -140,7 +147,9 @@ jobs:
           PYTEST_MD_REPORT: true
           PYTEST_MD_REPORT_VERBOSE: 0
           PYTEST_MD_REPORT_OUTPUT: pytest.md
+          PYTEST_ADDOPTS: "-rs --durations=10"
         run: |
+          source .env
           source build/this_acts_withdeps.sh
           pytest -rfExw -k "not gnn" -v
           cat ${PYTEST_MD_REPORT_OUTPUT} >> $GITHUB_STEP_SUMMARY
@@ -164,6 +173,7 @@ jobs:
         with:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           full_install: true
+          env_file: .env
 
       - uses: actions/download-artifact@v7
         with:
@@ -176,6 +186,7 @@ jobs:
         shell: bash
         run: |
           git config --global safe.directory "$GITHUB_WORKSPACE"
+          source .env
           source build/this_acts_withdeps.sh
           CI/physmon/phys_perf_mon.sh all physmon
 
@@ -242,6 +253,7 @@ jobs:
         with:
           compiler: ${{ matrix.cxx }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          env_file: .env
 
       - name: Restore ccache
         uses: actions/cache/restore@v5
@@ -255,6 +267,7 @@ jobs:
       - name: Configure
         run: >
           ccache -z &&
+          CI/dependencies/run.sh .env
           cmake -B build -S .
           --preset=github-ci
           -DCMAKE_CXX_COMPILER=${{ matrix.cxx }}
@@ -285,6 +298,7 @@ jobs:
 
       - name: Downstream configure
         run: >
+          CI/dependencies/run.sh .env
           cmake -B build-downstream -S Tests/DownstreamProject
           -GNinja
           -DCMAKE_BUILD_TYPE=Release
@@ -320,10 +334,13 @@ jobs:
         with:
           compiler: clang++
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          env_file: .env
 
       - name: Restore ccache
         uses: actions/cache/restore@v5
         id: ccache-restore
+        env:
+          DYLD_LIBRARY_PATH: ""
         with:
           path: ${{ env.CCACHE_DIR }}
           key: ccache-${{ runner.os  }}-${{ github.job }}-${{ env.CCACHE_KEY_SUFFIX }}-${{ github.sha }}
@@ -333,13 +350,11 @@ jobs:
       - name: Configure
         run: >
           ccache -z &&
+          CI/dependencies/run.sh .env
           cmake -B build -S .
           --preset=github-ci
           -DCMAKE_INSTALL_PREFIX="${{ env.INSTALL_DIR }}"
 
-      - run: ls -al /Users/runner/work/acts/acts/dependencies/view/lib
-      - run: find /Users/runner/work/acts/acts/dependencies/view/lib -type l -name "libRIO.*"
-
       - name: Build
         run: cmake --build build
 
@@ -354,10 +369,14 @@ jobs:
           key: ${{ steps.ccache-restore.outputs.cache-primary-key }}
 
       - name: Unit tests
-        run: cmake --build build --target test
+        run: >
+          CI/dependencies/run.sh .env
+          cmake --build build --target test
 
       - name: Integration tests
-        run: cmake --build build --target integrationtests
+        run: >
+          CI/dependencies/run.sh .env
+          cmake --build build --target integrationtests
 
       - name: Install
         run: cmake --build build --target install
@@ -369,6 +388,7 @@ jobs:
 
       - name: Downstream configure
         run: >
+          CI/dependencies/run.sh .env
           cmake -B build-downstream -S Tests/DownstreamProject
           -GNinja
           -DCMAKE_BUILD_TYPE=Release
@@ -379,9 +399,7 @@ jobs:
         run: cmake --build build-downstream
 
       - name: Downstream run
-        run: >
-          PATH="${{ env.DEPENDENCY_DIR }}/bin:$PATH"
-          && ./build-downstream/bin/ShowActsVersion
+        run: ./build-downstream/bin/ShowActsVersion
 
   external_eic-shell:
     runs-on: ubuntu-latest
@@ -409,7 +427,7 @@ jobs:
 
       - name: Build
         id: build
-        uses: eic/docker-run-action@v3
+        uses: eic/docker-run-action@v4
         continue-on-error: true
         with:
           image: "ghcr.io/eic/eic_ci_without_acts:nightly"
@@ -573,6 +591,7 @@ jobs:
         with:
           compiler: g++
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          env_file: .env
 
       - name: Restore ccache
         id: ccache-restore
@@ -587,13 +606,13 @@ jobs:
         run: ccache -z
 
       - name: Build wheel with pip
-        run: pip wheel . -v
+        run: CI/dependencies/run.sh .env pip wheel . -v
 
       - name: ccache stats
         run: ccache -s
 
       - name: Install wheel
-        run: pip install $(ls ./*.whl)
+        run: CI/dependencies/run.sh .env pip install $(ls ./*.whl)
 
       - name: Save ccache
         uses: actions/cache/save@v5
@@ -608,4 +627,4 @@ jobs:
           path: "*.whl"
 
       - name: Test
-        run: python3 -c "import acts; import acts.examples; v = acts.Vector3(1,2,3)"
+        run: CI/dependencies/run.sh .env python3 Python/Examples/scripts/hello_world_kalman.py

.github/workflows/sonarcloud.yml

@@ -31,6 +31,7 @@ jobs:
         with:
           compiler: g++
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          env_file: .env
 
       - name: 'Download artifact'
         uses: actions/github-script@v8
@@ -144,12 +145,11 @@ jobs:
         if: github.event.workflow_run.event == 'pull_request'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} # Put the name of your token here
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         with:
           args: >
             --define sonar.verbose=true
             --define sonar.cfamily.compile-commands=build/compile_commands.json
-            --define sonar.coverageReportPaths=build/coverage/cov.xml
             --define sonar.projectVersion=${{ steps.next_version.outputs.content }}
             --define sonar.scm.revision=${{ steps.pr_metadata.outputs.merge_sha }}
             --define sonar.pullrequest.key=${{ steps.pr_metadata.outputs.pr_number }}
@@ -161,7 +161,7 @@ jobs:
         if: github.event.workflow_run.event == 'push' && github.ref == 'refs/heads/main'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} # Put the name of your token here
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         with:
           args: >
             --define sonar.verbose=true