Implement generic acceleration structs

Author: niermann999

core/include/detray/builders/detector_builder.hpp

@@ -122,7 +122,7 @@ class detector_builder {
             vol_builder->build(det);
         }
 
-        det.set_volume_accelerator(std::move(m_vol_finder));
+        // TODO: Make fully generic for more volume accelerator types
 
         // TODO: Add sorting, data deduplication etc. here later...
 
@@ -152,7 +152,7 @@ class detector_builder {
     }
 
     /// Put the volumes into a search data structure
-    template <typename... Args>
+    /*template <typename... Args>
     DETRAY_HOST void set_volume_accelerator([[maybe_unused]] Args&&... args) {
         DETRAY_DEBUG("Setting volume finder for detector " << name());
 
@@ -184,13 +184,7 @@ class detector_builder {
         } else {
             m_vol_finder = vol_finder_t{args...};
         }
-    }
-
-    /// @returns access to the volume finder
-    DETRAY_HOST typename detector_type::volume_accelerator&
-    get_volume_accelerator() {
-        return m_vol_finder;
-    }
+    }*/
 
     private:
     /// Name of the new detector
@@ -199,7 +193,7 @@ class detector_builder {
     volume_data_t<std::unique_ptr<volume_builder_interface<detector_type>>>
         m_volumes{};
     /// Data structure to find volumes
-    typename detector_type::volume_accelerator m_vol_finder{};
+    // typename detector_type::volume_accelerator m_vol_finder{};
 };
 
 }  // namespace detray

core/include/detray/core/detector.hpp

@@ -131,20 +131,14 @@ class detector {
         volume_descriptor<geo_obj_ids, accel_link, material_link>;
     using volume_container = vector_type<volume_type>;
 
-    /// Volume finder definition: Make volume index available from track
-    /// position
-    using volume_accelerator =
-        typename metadata::template volume_accelerator<container_t>;
-
     /// Detector view types
     /// @TODO: Switch to const_view_type always if possible
     using view_type = dmulti_view<dvector_view<volume_type>,
                                   typename surface_lookup_container::view_type,
                                   typename transform_container::view_type,
                                   typename mask_container::view_type,
                                   typename material_container::view_type,
-                                  typename accelerator_container::view_type,
-                                  typename volume_accelerator::view_type>;
+                                  typename accelerator_container::view_type>;
 
     static_assert(concepts::device_view<view_type>,
                   "Detector view type ill-formed");
@@ -155,8 +149,7 @@ class detector {
                     typename transform_container::const_view_type,
                     typename mask_container::const_view_type,
                     typename material_container::const_view_type,
-                    typename accelerator_container::const_view_type,
-                    typename volume_accelerator::const_view_type>;
+                    typename accelerator_container::const_view_type>;
 
     static_assert(concepts::device_view<const_view_type>,
                   "Detector const view type ill-formed");
@@ -168,8 +161,7 @@ class detector {
                       typename transform_container::buffer_type,
                       typename mask_container::buffer_type,
                       typename material_container::buffer_type,
-                      typename accelerator_container::buffer_type,
-                      typename volume_accelerator::buffer_type>;
+                      typename accelerator_container::buffer_type>;
 
     static_assert(concepts::device_buffer<buffer_type>,
                   "Detector buffer type ill-formed");
@@ -196,8 +188,7 @@ class detector {
           _transforms(resource),
           _masks(resource),
           _materials(resource),
-          _accelerators(resource),
-          _volume_accelerator(resource) {}
+          _accelerators(resource) {}
 
     /// Constructor from detector data view
     template <concepts::device_view detector_view_t>
@@ -207,8 +198,7 @@ class detector {
           _transforms(detray::detail::get<2>(det_data.m_view)),
           _masks(detray::detail::get<3>(det_data.m_view)),
           _materials(detray::detail::get<4>(det_data.m_view)),
-          _accelerators(detray::detail::get<5>(det_data.m_view)),
-          _volume_accelerator(detray::detail::get<6>(det_data.m_view)) {}
+          _accelerators(detray::detail::get<5>(det_data.m_view)) {}
     /// @}
 
     /// @returns a string that contains the detector name
@@ -231,13 +221,14 @@ class detector {
     /// @return the volume by global cartesian @param position - const access
     DETRAY_HOST_DEVICE
     inline const auto &volume(const point3_type &p) const {
-        // The 3D cylindrical volume search grid is concentric
-        const transform3_type identity{};
-        const auto loc_pos =
-            _volume_accelerator.project(identity, p, identity.translation());
-
-        // Only one entry per bin
-        dindex volume_index{_volume_accelerator.search(loc_pos).value()};
+        volume_type v_desc{};
+        // Allow to call the volume search data structure
+        v_desc.set_accel_link(geo_obj_ids::e_volume, 0u);
+        tracking_volume world{v_desc, *this};
+
+        const dindex volume_index =
+            world.template visit_accelerator<geo_obj_ids::e_volume,
+                                             volume_search>(p);
         return _volumes[volume_index];
     }
 
@@ -287,48 +278,20 @@ class detector {
         return _accelerators;
     }
 
-    /// @return the volume grid - const access
-    DETRAY_HOST_DEVICE
-    inline auto get_volume_accelerator() const -> const volume_accelerator & {
-        return _volume_accelerator;
-    }
-
     /// @returns view of a detector
     DETRAY_HOST auto get_data() -> view_type {
-        return view_type{detray::get_data(_volumes),
-                         detray::get_data(_surfaces),
-                         detray::get_data(_transforms),
-                         detray::get_data(_masks),
-                         detray::get_data(_materials),
-                         detray::get_data(_accelerators),
-                         detray::get_data(_volume_accelerator)};
+        return view_type{
+            detray::get_data(_volumes),    detray::get_data(_surfaces),
+            detray::get_data(_transforms), detray::get_data(_masks),
+            detray::get_data(_materials),  detray::get_data(_accelerators)};
     }
 
     /// @returns const view of a detector
     DETRAY_HOST auto get_data() const -> const_view_type {
-        return const_view_type{detray::get_data(_volumes),
-                               detray::get_data(_surfaces),
-                               detray::get_data(_transforms),
-                               detray::get_data(_masks),
-                               detray::get_data(_materials),
-                               detray::get_data(_accelerators),
-                               detray::get_data(_volume_accelerator)};
-    }
-    /// Add the volume grid - move semantics
-    ///
-    /// @param v_grid the volume grid to be added
-    DETRAY_HOST
-    inline auto set_volume_accelerator(volume_accelerator &&v_grid) -> void {
-        _volume_accelerator = std::move(v_grid);
-    }
-
-    /// Add the volume grid - copy semantics
-    ///
-    /// @param v_grid the volume grid to be added
-    DETRAY_HOST
-    inline auto set_volume_accelerator(const volume_accelerator &v_grid)
-        -> void {
-        _volume_accelerator = v_grid;
+        return const_view_type{
+            detray::get_data(_volumes),    detray::get_data(_surfaces),
+            detray::get_data(_transforms), detray::get_data(_masks),
+            detray::get_data(_materials),  detray::get_data(_accelerators)};
     }
 
     private:
@@ -340,6 +303,26 @@ class detector {
         return os;
     }
 
+    /// Volume lookup in the volume acceleration data structures
+    struct volume_search {
+        ///@TODO: Move this to a volume search grid type
+        template <typename accel_group_t, typename accel_index_t>
+        DETRAY_HOST_DEVICE inline dindex operator()(
+            const accel_group_t &group, const accel_index_t index,
+            const point3_type &p) const {
+
+            const auto volume_accelerator = group[index];
+
+            // The 3D cylindrical volume search grid is concentric
+            const transform3_type identity{};
+            const auto loc_pos =
+                volume_accelerator.project(identity, p, identity.translation());
+
+            // Only one entry per bin
+            return volume_accelerator.search(loc_pos).value();
+        }
+    };
+
     /// Contains the detector sub-volumes.
     volume_container _volumes;
 
@@ -357,9 +340,6 @@ class detector {
 
     /// All surface finder data structures that are used in the detector volumes
     accelerator_container _accelerators;
-
-    /// Search structure for volumes
-    volume_accelerator _volume_accelerator;
 };
 
 }  // namespace detray

core/include/detray/geometry/detail/volume_kernels.hpp

@@ -14,6 +14,7 @@
 #include "detray/materials/detail/concepts.hpp"
 #include "detray/materials/detail/material_accessor.hpp"
 #include "detray/materials/material.hpp"
+#include "detray/navigation/concepts.hpp"
 
 namespace detray::detail {
 
@@ -43,20 +44,44 @@ struct get_material_params {
     }
 };
 
-/// A functor to access the surfaces of a volume
+/// A functor to access the surfaces of a volume in a particular acceleration
+/// structure
 template <typename functor_t>
 struct surface_getter {
 
-    /// Call operator that forwards the neighborhood search call in a volume
-    /// to a surface finder data structure
+    /// Call operator that forwards the functor to all contained surfaces
     template <typename accel_group_t, typename accel_index_t, typename... Args>
     DETRAY_HOST_DEVICE inline void operator()(const accel_group_t &group,
                                               const accel_index_t index,
                                               Args &&...args) const {
 
-        // Run over the surfaces in a single acceleration data structure
-        for (const auto &sf : group[index].all()) {
-            functor_t{}(sf, std::forward<Args>(args)...);
+        using accel_type = typename accel_group_t::value_type;
+
+        if constexpr (concepts::surface_accelerator<accel_type>) {
+            // Run over the surfaces in a single acceleration data structure
+            for (const auto &sf : group[index].all()) {
+                functor_t{}(sf, std::forward<Args>(args)...);
+            }
+        }
+    }
+};
+
+/// A functor to access the daughter volumes of a volume
+template <typename functor_t>
+struct daughter_volume_getter {
+
+    /// Call operator that forwards the functor call to all contained daughter
+    /// volumes
+    template <typename accel_group_t, typename accel_index_t, typename... Args>
+    DETRAY_HOST_DEVICE inline void operator()(const accel_group_t &group,
+                                              const accel_index_t index,
+                                              Args &&...args) const {
+
+        using accel_type = typename accel_group_t::value_type;
+
+        if constexpr (concepts::volume_accelerator<accel_type>) {
+            // Run over all the daughter volumes
+            // TODO: Implement e.g. BVH
         }
     }
 };

core/include/detray/geometry/tracking_volume.hpp

@@ -68,11 +68,17 @@ class tracking_volume {
     constexpr tracking_volume(const detector_t &det, const dindex vol_idx)
         : tracking_volume(det, det.volume(vol_idx)) {}
 
+    /// @returns true if the object ID corresponds to a surface
     static consteval bool is_surface_id(const object_id id) {
         return (id == object_id::e_portal || id == object_id::e_sensitive ||
                 id == object_id::e_passive);
     }
 
+    /// @returns true if the object ID corresponds to a [daughter] volume
+    static consteval bool is_volume_id(const object_id id) {
+        return (id == object_id::e_volume);
+    }
+
     /// @returns access to the underlying detector
     DETRAY_HOST_DEVICE
     auto detector() const -> const detector_t & { return m_detector; }

core/include/detray/materials/detail/material_accessor.hpp

@@ -41,7 +41,7 @@ DETRAY_HOST_DEVICE constexpr decltype(auto) get(
         &loc_point) noexcept {
 
     // Find the material slab (only one entry per bin)
-    return material_coll[idx].search(loc_point).ref();
+    return material_coll[idx].bin(loc_point).ref();
 }
 
 }  // namespace detray::detail::material_accessor