Generating pipeline with no steps

[orolega]

After updating to version 2.5.9, my pipeline is failing due to the generated pipeline having no steps. The paths that are watched in this step were not modified so I would expect them to be skipped rather than generating an empty pipeline.

So the pipeline.yaml looks like below. It is failing if I modify something in path "B" which isn't watched by this step.

plugins:
      - monebag/monorepo-diff#v2.5.9:
          diff: ".buildkite/diff.sh"
          watch:
            - path:
                - "A"
              config:
                .....

Output is like so:

Running diff command: .buildkite/diff.sh
Generated Pipeline:
steps: []

[adikari]

@orolega I will have a look into this next week when I have some free time. In this scenario, what used to happen before? Did it used to skip generating pipelines and no pipeline was uploaded?

[orolega]

Correct. It would skip generating anything for that step and begin the next step in the pipeline. I've outlined it a bit better below.

If we were to edit only something in the path "B" this pipeline fails now on Step A with that originalabove error, whereas before it would mark the step as complete without having done the command step.

Note I am aware that multiple path steps can be defined under watch. This is just a minimal reproducible example

  - label: "Step A"
    plugins:
      - monebag/monorepo-diff#v2.5.9:
          diff: ".buildkite/diff.sh"
          watch:
            - path:
                - "A"
              config:
                command: 'echo "Step A"'
  - label: "Step B"
    plugins:
      - monebag/monorepo-diff#v2.5.9:
          diff: ".buildkite/diff.sh"
          watch:
            - path:
                - "B"
              config:
                command: 'echo "Step B"'

To get around this we have had to add the below to every step as a work around which is not ideal

  - path:
      - "*"
      - "**/*"
      - ".*"
    config:
      command: 'echo "default"'

[adikari]

Thanks for additional info. Been bit busy this week. Will get back to this asap

[orolega]

Any movement on this? thanks

[orolega]

Bumping this again

[adikari]

I have been very busy lately and haven't gotten the chance to look into this. Will sort it out asap

[orolega]

bit more detail from the error message.

$ /var/lib/buildkite-agent/plugins/github-com-monebag-monorepo-diff-buildkite-plugin-v2-5-9/hooks/command
Using original buildkite agent from /tmp/buildkite-agent
INFO[0000] --- running monorepo-diff-buildkite-plugin 2.5.9
INFO[2023-11-15T00:31:16Z] Running diff command: .buildkite/diff.sh
Generated Pipeline:
steps: []
 
FATA[2023-11-15T00:31:21Z] +++ failed to upload pipeline: command `buildkite-agent` failed: exit status 1```

[orolega]

hey @adikari, not super versed in go but I gave an attempt at fixing this myself. Raised a PR

[adikari]

Thanks. I will have a look asap. Something came up at my day job and I have had almost no time at all.

[orolega]

@adikari happy holidays! Hopefully you can review soon.

[mayzenator]

hi! any update on this? kind of clunky to have to use the workaround mentioned in #143 on every step that uses this plugin

[orolega]

hi! any update on this? kind of clunky to have to use the workaround mentioned in #143 on every step that uses this plugin

@mayzenator I ended up closing this PR as buildkite has taken over the plugin. I re-raised it with them and its still open