Merge pull request #614 from adobe/fixSmells

fix: smells

Author: marshallpete

packages/vega-spec-builder/src/marks/markUtils.ts

@@ -193,10 +193,10 @@ export const getColorProductionRuleSignalString = (
     return colorRule.signal;
   }
   if ('scale' in colorRule && 'field' in colorRule) {
-    return `scale('${colorRule.scale}', datum.${colorRule.field})`;
+    return `scale('${colorRule.scale as string}', datum.${colorRule.field as string})`;
   }
   if ('value' in colorRule && colorRule.value) {
-    return `'${colorRule.value}'`;
+    return `'${colorRule.value as string}'`;
   }
   return '';
 };

packages/vega-spec-builder/src/scatter/scatterMarkUtils.ts

@@ -187,7 +187,7 @@ export const getSelectRingSize = (size: SymbolSizeFacet): NumericValueRef => {
     return { value: Math.pow(Math.sqrt(baseSize.value) + 4, 2) };
   }
   if ('scale' in baseSize && 'field' in baseSize) {
-    return { signal: `pow(sqrt(scale('${baseSize.scale}', datum.${baseSize.field})) + 4, 2)` };
+    return { signal: `pow(sqrt(scale('${baseSize.scale as string}', datum.${baseSize.field as string})) + 4, 2)` };
   }
   return baseSize;
 };