Merge pull request #589 from adobe/cloneBuiltSpec

Clone built spec

Author: tanugarg04

packages/react-spectrum-charts/src/hooks/useSpec.tsx

@@ -73,7 +73,7 @@ export default function useSpec({
 		});
 
 		// stringify-parse so that all immer stuff gets cleared out
-		return JSON.parse(JSON.stringify(buildSpec(chartOptions)));
+		return buildSpec(chartOptions);
 	}, [
 		UNSAFE_vegaSpec,
 		backgroundColor,

packages/vega-spec-builder/src/chartSpecBuilder.test.ts

@@ -391,7 +391,7 @@ describe('Chart spec builder', () => {
 				highlightedSeries: 'Chrome',
 			});
 
-			expect(spec.signals?.find((signal) => signal.name === HIGHLIGHTED_SERIES)).toStrictEqual({
+			expect(spec.signals?.find((signal) => signal.name === HIGHLIGHTED_SERIES)).toEqual({
 				name: HIGHLIGHTED_SERIES,
 				value: 'Chrome',
 			});
@@ -405,7 +405,7 @@ describe('Chart spec builder', () => {
 				highlightedSeries: 'Chrome',
 			});
 
-			expect(spec.signals?.find((signal) => signal.name === HIGHLIGHTED_SERIES)).toStrictEqual({
+			expect(spec.signals?.find((signal) => signal.name === HIGHLIGHTED_SERIES)).toEqual({
 				name: HIGHLIGHTED_SERIES,
 				value: 'Chrome',
 			});
@@ -432,7 +432,7 @@ describe('Chart spec builder', () => {
 				],
 			};
 
-			expect(spec.signals?.find((signal) => signal.name === 'highlightedSeries')).toStrictEqual(
+			expect(spec.signals?.find((signal) => signal.name === 'highlightedSeries')).toEqual(
 				uncontrolledHighlightSignal
 			);
 		});

packages/vega-spec-builder/src/chartSpecBuilder.ts

@@ -10,7 +10,7 @@
  * governing permissions and limitations under the License.
  */
 import { produce } from 'immer';
-import { Data, LinearScale, OrdinalScale, PointScale, Scale, Signal, Spec } from 'vega';
+import { Data, LinearScale, OrdinalScale, PointScale, Scale, Signal } from 'vega';
 
 import {
 	BACKGROUND_COLOR,
@@ -77,10 +77,6 @@ import {
 	SymbolSize,
 } from './types';
 
-export interface ChartSpecBuilder {
-	buildSpec: (options: ChartOptions) => Spec;
-}
-
 export function buildSpec({
 	axes = [],
 	backgroundColor = DEFAULT_BACKGROUND_COLOR,
@@ -194,7 +190,7 @@ export function buildSpec({
 	// clear out all scales that don't have any fields on the domain
 	spec = removeUnusedScales(spec);
 
-	return spec;
+	return safeClone(spec);
 }
 
 export const removeUnusedScales = produce<ScSpec>((spec) => {
@@ -422,3 +418,10 @@ export const isNumberArray = (opacities: Opacities): opacities is number[] => {
 export const isSymbolShapeArray = (symbolShapes: SymbolShapes): symbolShapes is ChartSymbolShape[] => {
 	return !symbolShapes.some((symbolShape) => Array.isArray(symbolShape));
 };
+
+const safeClone = <T>(obj: T): T => {
+	if (typeof structuredClone === 'function') {
+		return structuredClone(obj);
+	}
+	return JSON.parse(JSON.stringify(obj));
+};