chore: add validation for cron schedule

Signed-off-by: Artem Bortnikov <brongineer747@gmail.com>

Author: BROngineer

api/v1alpha1/etcdbackupschedule_types.go

@@ -35,9 +35,11 @@ type EtcdBackupScheduleSpec struct {
 	// Destination defines where the backup will be stored.
 	Destination BackupDestination `json:"destination"`
 	// SuccessfulJobsHistoryLimit is the number of successful finished CronJob children to retain.
+	// +kubebuilder:validation:Minimum=0
 	// +optional
 	SuccessfulJobsHistoryLimit *int32 `json:"successfulJobsHistoryLimit,omitempty"`
 	// FailedJobsHistoryLimit is the number of failed finished CronJob children to retain.
+	// +kubebuilder:validation:Minimum=0
 	// +optional
 	FailedJobsHistoryLimit *int32 `json:"failedJobsHistoryLimit,omitempty"`
 	// ActiveBackupJobDeadline is the duration in seconds that each scheduled

api/v1alpha1/etcdbackupschedule_webhook.go

@@ -18,6 +18,7 @@ package v1alpha1
 
 import (
 	"fmt"
+	"strings"
 
 	"github.com/robfig/cron/v3"
 	"k8s.io/apimachinery/pkg/api/errors"
@@ -119,6 +120,12 @@ func (r *EtcdBackupSchedule) validateSpec() field.ErrorList {
 			field.NewPath("spec", "schedule"),
 			"schedule is required",
 		))
+	} else if strings.HasPrefix(r.Spec.Schedule, "@every ") {
+		allErrors = append(allErrors, field.Invalid(
+			field.NewPath("spec", "schedule"),
+			r.Spec.Schedule,
+			"@every expressions are not supported by Kubernetes CronJobs",
+		))
 	} else if _, err := cronParser.Parse(r.Spec.Schedule); err != nil {
 		allErrors = append(allErrors, field.Invalid(
 			field.NewPath("spec", "schedule"),

config/crd/bases/etcd.aenix.io_etcdbackupschedules.yaml

@@ -145,6 +145,7 @@ spec:
                 description: FailedJobsHistoryLimit is the number of failed finished
                   CronJob children to retain.
                 format: int32
+                minimum: 0
                 type: integer
               finishedBackupJobsTTL:
                 default: 600
@@ -162,6 +163,7 @@ spec:
                 description: SuccessfulJobsHistoryLimit is the number of successful
                   finished CronJob children to retain.
                 format: int32
+                minimum: 0
                 type: integer
             required:
             - clusterRef