Replace AEP-143 custom function with JSONPath approach

Author: shakrav2

aep/0143.yaml

@@ -1,7 +1,6 @@
 functionsDir: ../functions
 functions:
   - standardized-codes
-  - standardized-codes-string-type
 
 rules:
   aep-143-standardized-codes:
@@ -14,10 +13,19 @@ rules:
       function: standardized-codes
 
   aep-143-standardized-codes-string-type:
-    description: Standardized code fields must be of type string.
-    message: '{{error}}'
+    description: Standardized code fields must be of type "string".
+    message: 'Standardized code field "{{property}}" must be type "string"'
     severity: error
     formats: ['oas2', 'oas3']
-    given: $.components.schemas[*]
+    given:
+      - $.components.schemas[*].properties[?(@property in ['content_type', 'currency_code', 'language_code'])]
+      - $.components.schemas[*].properties[?(@property in ['region_code', 'time_zone', 'utc_offset'])]
     then:
-      function: standardized-codes-string-type
+      function: schema
+      functionOptions:
+        schema:
+          type: object
+          required: ['type']
+          properties:
+            type:
+              const: string

functions/standardized-codes-string-type.js

@@ -21,7 +21,6 @@ functions:
   - parameter-names-unique
   - operations-endpoint
   - standardized-codes
-  - standardized-codes-string-type
 rules:
   openapi-tags: off
   operation-tags: off

spectral.yaml

@@ -29,7 +29,7 @@ describe('aep-143-standardized-codes-string-type', () => {
       expect(results.length).toBe(1);
       expect(results).toContainMatch({
         path: ['components', 'schemas', 'Book', 'properties', 'language_code', 'type'],
-        message: expect.stringContaining('should be of type "string"'),
+        message: expect.stringContaining('must be type "string"'),
       });
     });
   });
@@ -54,7 +54,7 @@ describe('aep-143-standardized-codes-string-type', () => {
       expect(results.length).toBe(1);
       expect(results).toContainMatch({
         path: ['components', 'schemas', 'Address', 'properties', 'region_code', 'type'],
-        message: expect.stringContaining('should be of type "string"'),
+        message: expect.stringContaining('must be type "string"'),
       });
     });
   });
@@ -79,7 +79,7 @@ describe('aep-143-standardized-codes-string-type', () => {
       expect(results.length).toBe(1);
       expect(results).toContainMatch({
         path: ['components', 'schemas', 'Price', 'properties', 'currency_code', 'type'],
-        message: expect.stringContaining('should be of type "string"'),
+        message: expect.stringContaining('must be type "string"'),
       });
     });
   });
@@ -104,7 +104,7 @@ describe('aep-143-standardized-codes-string-type', () => {
       expect(results.length).toBe(1);
       expect(results).toContainMatch({
         path: ['components', 'schemas', 'File', 'properties', 'content_type', 'type'],
-        message: expect.stringContaining('should be of type "string"'),
+        message: expect.stringContaining('must be type "string"'),
       });
     });
   });
@@ -129,7 +129,7 @@ describe('aep-143-standardized-codes-string-type', () => {
       expect(results.length).toBe(1);
       expect(results).toContainMatch({
         path: ['components', 'schemas', 'Event', 'properties', 'time_zone', 'type'],
-        message: expect.stringContaining('should be of type "string"'),
+        message: expect.stringContaining('must be type "string"'),
       });
     });
   });
@@ -154,7 +154,7 @@ describe('aep-143-standardized-codes-string-type', () => {
       expect(results.length).toBe(1);
       expect(results).toContainMatch({
         path: ['components', 'schemas', 'TimeInfo', 'properties', 'utc_offset', 'type'],
-        message: expect.stringContaining('should be of type "string"'),
+        message: expect.stringContaining('must be type "string"'),
       });
     });
   });