chore: make icepq_field_bound_values a faillible function (does not immediately break query but returns either result|error)

Author: arnaudbriche

cmd/clickhouse/function/field_bound_values/field_bound_values.go

@@ -8,6 +8,7 @@ import (
 
 	"github.com/ClickHouse/ch-go/proto"
 	ice "github.com/agnosticeng/icepq/internal/iceberg"
+	"github.com/samber/lo"
 	"github.com/sourcegraph/conc/iter"
 	"github.com/urfave/cli/v2"
 )
@@ -25,7 +26,7 @@ func Command() *cli.Command {
 				buf                   proto.Buffer
 				inputTableLocationCol = new(proto.ColStr)
 				inputFieldNameCol     = new(proto.ColStr)
-				outputResultCol       = new(proto.ColStr).Array()
+				outputResultCol       = new(proto.ColBytes)
 
 				input = proto.Results{
 					{Name: "table_location", Data: inputTableLocationCol},
@@ -67,22 +68,30 @@ func Command() *cli.Command {
 					)
 
 					if err != nil {
-						return err
+						outputResultCol.Append(lo.Must(json.Marshal(map[string]any{
+							"error": err.Error(),
+						})))
+						continue
 					}
 
-					res, err := iter.MapErr(values, func(item *ice.FieldBoundValuesItem) (string, error) {
+					res, err := iter.MapErr(values, func(item *ice.FieldBoundValuesItem) (json.RawMessage, error) {
 						js, err := json.Marshal(item)
 						if err != nil {
-							return "", err
+							return nil, err
 						}
-						return string(js), nil
+						return js, nil
 					})
 
 					if err != nil {
-						return err
+						outputResultCol.Append(lo.Must(json.Marshal(map[string]any{
+							"error": err.Error(),
+						})))
+						continue
 					}
 
-					outputResultCol.Append(res)
+					outputResultCol.Append(lo.Must(json.Marshal(map[string]any{
+						"value": res,
+					})))
 				}
 
 				var outputblock = proto.Block{

config/icepq_field_bound_values_function.xml

@@ -17,6 +17,6 @@
             <type>String</type>
         </argument>
 
-        <return_type>Array(JSON)</return_type>
+        <return_type>JSON</return_type>
     </function>
 </functions>