Do not create runnable to synchronously inflated views

Author: Varun Gupta

epoxy-adapter/src/main/java/com/airbnb/epoxy/BaseEpoxyAdapter.java

@@ -108,8 +108,12 @@ public void onBindViewHolder(EpoxyViewHolder holder, int position) {
 
   @Override
   public void onBindViewHolder(EpoxyViewHolder holder, int position, List<Object> payloads) {
-    executeWhenInflated(holder,
-        () -> onBindViewHolderInternal(holder, holder.getBindingAdapterPosition(), payloads));
+    if (holder.itemView instanceof AsyncInflatedView) {
+      ((AsyncInflatedView)holder.itemView).executeWhenInflated(() ->
+          onBindViewHolderInternal(holder, holder.getBindingAdapterPosition(), payloads));
+    } else {
+      onBindViewHolderInternal(holder, holder.getBindingAdapterPosition(), payloads);
+    }
   }
 
   private void onBindViewHolderInternal(EpoxyViewHolder holder, int position, List<Object> payloads) {
@@ -214,19 +218,27 @@ public boolean onFailedToRecycleView(EpoxyViewHolder holder) {
   @CallSuper
   @Override
   public void onViewAttachedToWindow(EpoxyViewHolder holder) {
-    executeWhenInflated(holder,
-        () ->
-            //noinspection unchecked,rawtypes
-            ((EpoxyModel) holder.getModel()).onViewAttachedToWindow(holder.objectToBind()));
+    if (holder.itemView instanceof AsyncInflatedView) {
+      ((AsyncInflatedView)holder.itemView).executeWhenInflated(() ->
+          //noinspection unchecked,rawtypes
+          ((EpoxyModel) holder.getModel()).onViewAttachedToWindow(holder.objectToBind()));
+    } else {
+        //noinspection unchecked,rawtypes
+        ((EpoxyModel) holder.getModel()).onViewAttachedToWindow(holder.objectToBind());
+    }
   }
 
   @CallSuper
   @Override
   public void onViewDetachedFromWindow(EpoxyViewHolder holder) {
-    executeWhenInflated(holder,
-        () ->
-            //noinspection unchecked,rawtypes
-            ((EpoxyModel) holder.getModel()).onViewDetachedFromWindow(holder.objectToBind()));
+    if (holder.itemView instanceof AsyncInflatedView) {
+      ((AsyncInflatedView)holder.itemView).executeWhenInflated(() ->
+          //noinspection unchecked,rawtypes
+          ((EpoxyModel) holder.getModel()).onViewDetachedFromWindow(holder.objectToBind()));
+    } else {
+      //noinspection unchecked,rawtypes
+      ((EpoxyModel) holder.getModel()).onViewDetachedFromWindow(holder.objectToBind());
+    }
   }
 
   public void onSaveInstanceState(Bundle outState) {
@@ -348,12 +360,4 @@ public boolean isStickyHeader(int position) {
   }
 
   //endregion
-
-  protected void executeWhenInflated(EpoxyViewHolder holder, Runnable runnable) {
-    if (holder.itemView instanceof AsyncInflatedView) {
-      ((AsyncInflatedView)holder.itemView).executeWhenInflated(runnable);
-    } else {
-      runnable.run();
-    }
-  }
 }

epoxy-adapter/src/main/java/com/airbnb/epoxy/EpoxyControllerAdapter.java

@@ -125,15 +125,23 @@ public void onDetachedFromRecyclerView(@NonNull RecyclerView recyclerView) {
   @Override
   public void onViewAttachedToWindow(@NonNull EpoxyViewHolder holder) {
     super.onViewAttachedToWindow(holder);
-    executeWhenInflated(holder,
-        () -> epoxyController.onViewAttachedToWindow(holder, holder.getModel()));
+    if (holder.itemView instanceof AsyncInflatedView) {
+      ((AsyncInflatedView)holder.itemView).executeWhenInflated(() ->
+          epoxyController.onViewAttachedToWindow(holder, holder.getModel()));
+    } else {
+      epoxyController.onViewAttachedToWindow(holder, holder.getModel());
+    }
   }
 
   @Override
   public void onViewDetachedFromWindow(@NonNull EpoxyViewHolder holder) {
     super.onViewDetachedFromWindow(holder);
-    executeWhenInflated(holder,
-        () -> epoxyController.onViewDetachedFromWindow(holder, holder.getModel()));
+    if (holder.itemView instanceof AsyncInflatedView) {
+      ((AsyncInflatedView)holder.itemView).executeWhenInflated(() ->
+          epoxyController.onViewDetachedFromWindow(holder, holder.getModel()));
+    } else {
+      epoxyController.onViewDetachedFromWindow(holder, holder.getModel());
+    }
   }
 
   @Override