-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Description
Summary
Requested by Teo (@tgonzalezc5) (teo@airbyte.io).
When pulling data from the Facebook Marketing source connector, the action_attribution_windows parameter sent to the Facebook Insights API should include the engaged view (ev) attribution window types in addition to the existing click and view windows.
Current Behavior
The connector currently requests the following action_attribution_windows (defined in ALL_ACTION_ATTRIBUTION_WINDOWS in base_insight_streams.py):
1d_click7d_click28d_click1d_view
This means streams like custom insights reporting (e.g. custom_table_actions, custom_table_action_values) only include click and 1d_view attribution data.
Expected Behavior
The connector should also request the following engaged view attribution windows:
1d_ev7d_ev28d_ev
These are valid Facebook Marketing API attribution windows and are needed to get complete attribution reporting data.
Relevant Code
source_facebook_marketing/streams/base_insight_streams.py(line 35-40) βALL_ACTION_ATTRIBUTION_WINDOWSlist
Impact
This affects all Ads Insights streams that use action_attribution_windows in their API requests. Adding the ev windows will surface engaged view attribution data in action-related fields (e.g. actions, action_values, cost_per_action_type, etc.).
Considerations
- Adding new attribution windows is a schema change β new
*_1d_ev,*_7d_ev,*_28d_evcolumns will appear in action stats objects. - This should be evaluated for whether it constitutes a breaking change (new columns appearing in existing streams). Since these are additive columns, this may be non-breaking.
- The JSON schemas for action stats (
shared/ads_action_stats.json) will need to be updated to include the newevwindow properties.
Internal Tracking: https://github.com/airbytehq/oncall/issues/11511