record the reason an install failed

Install state now stores an error message alongside the failed status and
the container status route returns it, so panels can tell users why the
install broke instead of a bare 'failed'.

Author: bthavanish

src/handlers/installState.ts

@@ -2,33 +2,52 @@ import { join } from 'node:path';
 
 const logsPath = join(process.cwd(), 'storage/install_logs.json');
 
-async function readState(): Promise<Record<string, string>> {
+export interface InstallStatus {
+  state: string;
+  error?: string;
+}
+
+async function readState(): Promise<Record<string, InstallStatus>> {
   try {
     const file = Bun.file(logsPath);
     const text = await file.text();
-    return JSON.parse(text);
+    const parsed = JSON.parse(text);
+    const entries = Object.entries(parsed).map(([id, value]) => {
+      if (value && typeof value === 'object') {
+        return [id, value] as [string, InstallStatus];
+      }
+      // legacy flat string format
+      return [id, { state: String(value) }] as [string, InstallStatus];
+    });
+    return Object.fromEntries(entries);
   } catch {
     return {};
   }
 }
 
-async function writeState(data: Record<string, string>): Promise<void> {
+async function writeState(data: Record<string, InstallStatus>): Promise<void> {
   await Bun.write(logsPath, JSON.stringify(data, null, 2));
 }
 
-export async function setServerState(containerId: string, state: string): Promise<void> {
+export async function setServerState(containerId: string, state: string, error?: string): Promise<void> {
   const logs = await readState();
-  logs[containerId] = state;
+  logs[containerId] = error ? { state, error } : { state };
   await writeState(logs);
 }
 
 export async function getServerState(containerId: string): Promise<string | undefined> {
+  const logs = await readState();
+  return logs[containerId]?.state;
+}
+
+export async function getInstallStatus(containerId: string): Promise<InstallStatus | undefined> {
   const logs = await readState();
   return logs[containerId];
 }
 
 export async function getAllServerStates(): Promise<Record<string, string>> {
-  return readState();
+  const logs = await readState();
+  return Object.fromEntries(Object.entries(logs).map(([id, s]) => [id, s.state]));
 }
 
 export async function removeServerState(containerId: string): Promise<void> {

src/routes/instances.ts

@@ -17,7 +17,7 @@ import {
   stopContainer,
 } from '../handlers/docker';
 import { copyIntoVolume, downloadToVolume } from '../handlers/fs';
-import { getServerState, setServerState } from '../handlers/installState';
+import { getInstallStatus, setServerState } from '../handlers/installState';
 import logger from '../logger';
 import { validateContainerId } from '../validation';
 import { clearLogBuffer, getLogBuffer } from '../ws/server';
@@ -176,7 +176,7 @@ export async function handleContainerInstaller(req: Request): Promise<Response>
     return json({ message: `container ${id} installed successfully` });
   } catch (error) {
     logger.error('error installing container', error);
-    await setServerState(id, 'failed');
+    await setServerState(id, 'failed', error instanceof Error ? error.message : String(error));
     return json({ error: `failed to install container ${id}` }, 500);
   }
 }
@@ -209,7 +209,7 @@ export async function handleContainerInstall(req: Request): Promise<Response> {
       await setServerState(id, 'installed');
     } catch (err) {
       logger.error('error during async install', err);
-      await setServerState(id, 'failed');
+      await setServerState(id, 'failed', err instanceof Error ? err.message : String(err));
     }
   })();
 
@@ -246,7 +246,7 @@ export async function handleContainerReinstall(req: Request): Promise<Response>
       await setServerState(id, 'installed');
     } catch (err) {
       logger.error('error during async reinstall', err);
-      await setServerState(id, 'failed');
+      await setServerState(id, 'failed', err instanceof Error ? err.message : String(err));
     }
   })();
 
@@ -347,9 +347,9 @@ export async function handleContainerInstallStatus(_req: Request, params: Record
   if (!id) return json({ error: 'container ID is required' }, 400);
   if (!validateContainerId(id)) return json({ error: 'invalid container ID' }, 400);
 
-  const state = await getServerState(id);
-  if (!state) return json({ message: `no install state found for container ${id}` }, 404);
-  return json({ containerId: id, state });
+  const status = await getInstallStatus(id);
+  if (!status) return json({ message: `no install state found for container ${id}` }, 404);
+  return json({ containerId: id, state: status.state, error: status.error });
 }
 
 export async function handleContainerStart(req: Request): Promise<Response> {