fix: use AST-based formatter in LSP instead of basic line indentation (#368)

The LSP formatting handler was using a simple line-by-line indenter
that didn't properly reformat SQL. Now uses gosqlx.Format() which
parses SQL into an AST and produces properly formatted output,
matching the CLI's format command behavior.

Co-authored-by: Ajit Pratap Singh <ajitpratapsingh@Ajits-Mac-mini-2655.local>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: 3 people

CHANGELOG.md

@@ -5,6 +5,11 @@ All notable changes to GoSQLX will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.10.4] - 2026-03-14 — AST-based LSP Formatting
+
+### Fixed
+- LSP formatting now uses the full AST-based formatter instead of basic line indentation
+
 ## [1.10.3] - 2026-03-14 — LSP --stdio compatibility
 
 ### Fixed

cmd/gosqlx/cmd/doc.go

@@ -341,7 +341,7 @@
 //
 // Version information:
 //
-//	Version = "1.10.3" - Current CLI version
+//	Version = "1.10.4" - Current CLI version
 //
 // # Dependencies
 //

cmd/gosqlx/cmd/root.go

@@ -28,12 +28,12 @@ import (
 // This version tracks feature releases and compatibility.
 // Format: MAJOR.MINOR.PATCH (Semantic Versioning 2.0.0)
 //
-// Version 1.10.3 includes:
+// Version 1.10.4 includes:
 //   - MCP Server: All GoSQLX SQL capabilities as Model Context Protocol tools over streamable HTTP
 //   - 7 MCP tools: validate_sql, format_sql, parse_sql, extract_metadata, security_scan, lint_sql, analyze_sql
 //   - Optional bearer token auth via GOSQLX_MCP_AUTH_TOKEN
 //   - Go minimum bumped to 1.23.0 (required by mark3labs/mcp-go)
-var Version = "1.10.3"
+var Version = "1.10.4"
 
 var (
 	// verbose enables detailed output for debugging and troubleshooting.
@@ -121,7 +121,7 @@ Key features:
 • CI/CD integration with proper exit codes
 
 Performance: 1.5M+ operations/second sustained, 1.97M peak. 100-1000x faster than competitors.`,
-	Version: "1.10.3",
+	Version: "1.10.4",
 }
 
 // Execute adds all child commands to the root command and sets flags appropriately.

cmd/gosqlx/doc.go

@@ -24,7 +24,7 @@
 //
 // # Version
 //
-// Current version: 1.10.3
+// Current version: 1.10.4
 //
 // # Architecture
 //

doc.go

@@ -16,7 +16,7 @@
 // zero-copy tokenization and comprehensive object pooling. It offers enterprise-grade SQL lexing,
 // parsing, and AST generation with support for multiple SQL dialects and advanced SQL features.
 //
-// GoSQLX v1.10.3 includes both a powerful Go SDK and a high-performance CLI tool for SQL processing,
+// GoSQLX v1.10.4 includes both a powerful Go SDK and a high-performance CLI tool for SQL processing,
 // validated for production deployment with race-free concurrent operation and extensive real-world testing.
 //
 // Production Status: VALIDATED FOR PRODUCTION DEPLOYMENT (v1.6.0+)
@@ -278,7 +278,7 @@
 //
 // # Version History
 //
-// v1.10.3: VS Code Marketplace publishing with bundled platform-specific binaries
+// v1.10.4: VS Code Marketplace publishing with bundled platform-specific binaries
 // v1.10.0: MCP Server — all SQL tools as Model Context Protocol tools over streamable HTTP
 // v1.9.0: SQLite PRAGMA, tautology detection, 19 post-UAT fixes
 // v1.8.0: Multi-dialect engine, query transforms, WASM playground, AST-to-SQL roundtrip

llms.txt

@@ -7,7 +7,7 @@ recursive-descent parsing, and AST generation with comprehensive object pooling.
 PostgreSQL, MySQL, SQL Server, Oracle, SQLite, and Snowflake dialects, and ships a full-featured
 CLI tool (`gosqlx`) for validation, formatting, linting, and security analysis. Apache-2.0 licensed.
 
-Current stable version: v1.10.3 (2026-03-13)
+Current stable version: v1.10.4 (2026-03-13)
 
 ## Core API
 

performance_baselines.json

@@ -1,5 +1,5 @@
 {
-  "version": "1.10.3",
+  "version": "1.10.4",
   "updated": "2026-03-13",
   "baselines": {
     "SimpleSelect": {

pkg/gosqlx/gosqlx.go

@@ -28,7 +28,7 @@ import (
 )
 
 // Version is the current GoSQLX library version.
-const Version = "1.10.3"
+const Version = "1.10.4"
 
 // Parse tokenizes and parses SQL in one call, returning an Abstract Syntax Tree (AST).
 //

pkg/lsp/handler.go

@@ -688,8 +688,16 @@ func (h *Handler) handleFormatting(params json.RawMessage) ([]TextEdit, error) {
 		return nil, nil
 	}
 
-	// Format the SQL using a simple formatter
-	formatted := formatSQL(content, p.Options)
+	// Format the SQL using the full AST-based formatter
+	opts := gosqlx.DefaultFormatOptions()
+	if p.Options.InsertSpaces {
+		opts.IndentSize = p.Options.TabSize
+	}
+	formatted, err := gosqlx.Format(content, opts)
+	if err != nil {
+		// If parsing fails, fall back to basic formatting
+		formatted = formatSQL(content, p.Options)
+	}
 	if formatted == content {
 		return []TextEdit{}, nil
 	}

pkg/mcp/server.go

@@ -35,7 +35,7 @@ func New(cfg *Config) *Server {
 	s := &Server{cfg: cfg}
 	s.mcpSrv = mcpserver.NewMCPServer(
 		"gosqlx-mcp",
-		"1.10.3",
+		"1.10.4",
 		mcpserver.WithToolCapabilities(false),
 	)
 	s.registerTools()