Refactor: Introduce CrashlyticsHelper for testability and add ShowDetailRepository tests

Author: akitikkx

app/src/main/java/com/theupnextapp/di/FirebaseCrashlyticsModule.kt

@@ -34,17 +34,18 @@ import javax.inject.Singleton
 @Module
 abstract class FirebaseCrashlyticsModule {
 
-    companion object { // Added companion object
+    @Binds
+    @Singleton
+    abstract fun bindCrashlyticsHelper(
+        appCrashlyticsHelper: AppCrashlyticsHelper
+    ): CrashlyticsHelper
+
+    companion object {
         @Singleton
         @Provides
         fun provideFirebaseCrashlytics(): FirebaseCrashlytics {
             return FirebaseCrashlytics.getInstance()
         }
     }
 
-    @Binds
-    @Singleton
-    abstract fun bindCrashlyticsHelper(
-        appCrashlyticsHelper: AppCrashlyticsHelper
-    ): CrashlyticsHelper
 }

app/src/main/java/com/theupnextapp/domain/Result.kt

@@ -21,7 +21,6 @@
 
 package com.theupnextapp.domain
 
-import android.util.Log
 import com.squareup.moshi.Moshi
 import kotlinx.coroutines.CoroutineDispatcher
 import kotlinx.coroutines.withContext

app/src/main/java/com/theupnextapp/repository/ShowDetailRepository.kt

@@ -21,8 +21,6 @@
 
 package com.theupnextapp.repository
 
-import androidx.lifecycle.LiveData
-import androidx.lifecycle.MutableLiveData
 import com.theupnextapp.common.CrashlyticsHelper
 import com.theupnextapp.database.UpnextDao
 import com.theupnextapp.domain.Result
@@ -47,7 +45,7 @@ class ShowDetailRepository(
     private val crashlytics: CrashlyticsHelper
 ) : BaseRepository(upnextDao = upnextDao, tvMazeService = tvMazeService) {
 
-    suspend fun getShowSummary(showId: Int): Flow<Result<ShowDetailSummary>> {
+    fun getShowSummary(showId: Int): Flow<Result<ShowDetailSummary>> {
         return flow {
             emit(Result.Loading(true))
             val response =
@@ -73,7 +71,7 @@ class ShowDetailRepository(
             .flowOn(Dispatchers.IO)
     }
 
-    suspend fun getPreviousEpisode(episodeRef: String?): Flow<Result<ShowPreviousEpisode>> {
+    fun getPreviousEpisode(episodeRef: String?): Flow<Result<ShowPreviousEpisode>> {
         return flow {
             emit(Result.Loading(true))
             val previousEpisodeLink = episodeRef?.substring(
@@ -109,7 +107,7 @@ class ShowDetailRepository(
             .flowOn(Dispatchers.IO)
     }
 
-    suspend fun getNextEpisode(episodeRef: String?): Flow<Result<ShowNextEpisode>> {
+    fun getNextEpisode(episodeRef: String?): Flow<Result<ShowNextEpisode>> {
         return flow {
             emit(Result.Loading(true))
             val nextEpisodeLink = episodeRef?.substring(
@@ -145,7 +143,7 @@ class ShowDetailRepository(
             .flowOn(Dispatchers.IO)
     }
 
-    suspend fun getShowCast(showId: Int): Flow<Result<List<ShowCast>>> {
+    fun getShowCast(showId: Int): Flow<Result<List<ShowCast>>> {
         return flow {
             emit(Result.Loading(true))
             val response = safeApiCall(Dispatchers.IO) {
@@ -170,7 +168,7 @@ class ShowDetailRepository(
             .flowOn(Dispatchers.IO)
     }
 
-    suspend fun getShowSeasons(showId: Int): Flow<Result<List<ShowSeason>>> {
+    fun getShowSeasons(showId: Int): Flow<Result<List<ShowSeason>>> {
         return flow {
             emit(Result.Loading(true))
             val response = safeApiCall(Dispatchers.IO) {
@@ -195,7 +193,7 @@ class ShowDetailRepository(
             .flowOn(Dispatchers.IO)
     }
 
-    suspend fun getShowSeasonEpisodes(
+    fun getShowSeasonEpisodes(
         showId: Int,
         seasonNumber: Int
     ): Flow<Result<List<ShowSeasonEpisode>>> {

app/src/test/java/com/theupnextapp/fake/FakeTvMazeService.kt

@@ -137,41 +137,59 @@ class FakeTvMazeService : TvMazeService {
         if (shouldThrowGetShowSummaryError) {
             throw IOException("Fake network error for getShowSummary")
         }
-        mockShowInfoResponse?.let {
-            return CompletableDeferred(it)
-        } ?: throw NotImplementedError("mockShowInfoResponse not set for this test")
+        val currentMock = mockShowInfoResponse
+        if (currentMock != null) {
+            return CompletableDeferred(currentMock)
+        } else {
+            throw NotImplementedError("mockShowInfoResponse not set for this test")
+        }
     }
 
     override fun getNextEpisodeAsync(name: String?): Deferred<NetworkShowNextEpisodeResponse> {
-        mockNextEpisodeResponse?.let {
-            return CompletableDeferred(it)
-        } ?: throw NotImplementedError("mockNextEpisodeResponse not set for this test")
+        val currentMock = mockNextEpisodeResponse
+        if (currentMock != null) {
+            return CompletableDeferred(currentMock)
+        } else {
+            throw NotImplementedError("mockNextEpisodeResponse not set for this test")
+        }
     }
 
     override fun getPreviousEpisodeAsync(name: String?): Deferred<NetworkShowPreviousEpisodeResponse> {
         if (shouldThrowGetPreviousEpisodeError) {
             throw IOException("Fake network error for getPreviousEpisode")
         }
-        mockPreviousEpisodeResponse?.let {
-            return CompletableDeferred(it)
-        } ?: throw NotImplementedError("mockPreviousEpisodeResponse not set for this test")
+        val currentMock = mockPreviousEpisodeResponse
+        if (currentMock != null) {
+            return CompletableDeferred(currentMock)
+        } else {
+            throw NotImplementedError("mockPreviousEpisodeResponse not set for this test")
+        }
     }
 
     override fun getShowCastAsync(id: String?): Deferred<NetworkShowCastResponse> {
-        mockShowCastResponse?.let {
-            return CompletableDeferred(it)
-        } ?: throw NotImplementedError("mockShowCastResponse not set for this test")
+        val currentMock = mockShowCastResponse
+        if (currentMock != null) {
+            return CompletableDeferred(currentMock)
+        } else {
+            throw NotImplementedError("mockShowCastResponse not set for this test")
+        }
     }
 
     override fun getShowSeasonsAsync(id: String?): Deferred<NetworkShowSeasonsResponse> {
-        mockShowSeasonsResponse?.let {
-            return CompletableDeferred(it)
-        } ?: throw NotImplementedError("mockShowSeasonsResponse not set for this test")
+        val currentMock = mockShowSeasonsResponse
+        if (currentMock != null) {
+            return CompletableDeferred(currentMock)
+        } else {
+            throw NotImplementedError("mockShowSeasonsResponse not set for this test")
+        }
     }
 
     override fun getSeasonEpisodesAsync(id: String?): Deferred<NetworkTvMazeEpisodesResponse> {
-        mockTvMazeEpisodesResponse?.let {
-            return CompletableDeferred(it)
-        } ?: throw NotImplementedError("mockTvMazeEpisodesResponse not set for this test")
+        val currentMock = mockTvMazeEpisodesResponse
+        if (currentMock != null) {
+            return CompletableDeferred(currentMock)
+        } else {
+            throw NotImplementedError("mockTvMazeEpisodesResponse not set for this test")
+        }
     }
 }

app/src/test/java/com/theupnextapp/fake/FakeUpnextDao.kt

@@ -42,14 +42,4 @@ class FakeUpnextDao : UpnextDao {
         tableUpdates.remove(tableName)
         tableUpdatesFlow.value = HashMap(tableUpdates) // Emit new state
     }
-
-    // Helper for tests
-    fun clearAll() {
-        tableUpdates.clear()
-        tableUpdatesFlow.value = emptyMap()
-    }
-
-    fun addTableUpdate(update: DatabaseTableUpdate) {
-        insertTableUpdateLog(update)
-    }
 }