Skip to content

[V3] ReceiveActor - Removing MatchBuilder and making use of handlers. Deleted all MatchHandler code #7557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Mar 21, 2025
Merged

[V3] ReceiveActor - Removing MatchBuilder and making use of handlers. Deleted all MatchHandler code #7557

merged 23 commits into from
Mar 21, 2025

Conversation

@Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Mar 20, 2025 •
edited
Loading

Changes

Full-blown version of #7556 - deletes all MatchHandler code and upgrades the PersistentReceiveActor to also use the new ReceiveMatchHandlers

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

mhbuck and others added 21 commits February 3, 2025 21:52
@mhbuck
Initial working approach but very rough.
520ea0b
@mhbuck
Consolidate
586cd7d
@mhbuck
Potentially cleaner approach
4d5a53c
@mhbuck
Some clean up and comments.
9ac82d3
@mhbuck
Remove using
8480ac6
@mhbuck
Added test and logic to prevent Any handler from being added twice
9dd025c
@mhbuck
Wanting to confirm these tests are also passing on build
76b4a1f 
This is probably not the most ideal code. I want to make sure the tests are passing better before getting to cleaning it up
@mhbuck
TryHandle looks much neater
0e5f8d3
@mhbuck
Closer to what I think the final layout will be
ff1f8f1
@mhbuck
Moved classes out and starting on tests
0a55a59 
Still quite a bit of understanding of how the MatchBuilder was working
@mhbuck
Test update.
8c59776
@mhbuck
More refinement
bc7beca
@mhbuck
Getting more tests
2e938f7
@mhbuck
Covering a bunch of the test cases
2cdeaa7
@mhbuck
Minor Tweak
5db8c97
@Aaronontheweb
v1.6 - adjust ReceiveActorHandlers to ensure preservation of declar…
a41ba78 
…ed `Receive<T>` ordering

a continuation of akkadotnet#7498
@Aaronontheweb
removed comment
f4742ad
@Aaronontheweb
removed all MatchHandler garbage
9e541fd
@Aaronontheweb
made ReceiveActor nullable
c6f7bd5
@Aaronontheweb
convert ReceiveActor.cs back to UTF-8
8c9ed06
@Aaronontheweb
removed all MatchHandler references from ReceivePersistentActor
da96c68
@Aaronontheweb Aaronontheweb added akka-persistence akka-actor AOT Ahead-of-Time (AOT) Compilation labels Mar 20, 2025
@Aaronontheweb
Copy link
Member Author

Aaronontheweb commented Mar 20, 2025

This is going to fail API approvals since I made both the ReceiveActor and the PersistentActor nullable

@Aaronontheweb Aaronontheweb added the akka.net v1.6 Akka.NET v1.6-related issues label Mar 20, 2025
@Aaronontheweb
Copy link
Member Author

Aaronontheweb commented Mar 21, 2025

Looks like there are some Akka.Persistence specs failing where we are not handling Become properly inside the PersistentReceiveActor

@Aaronontheweb Aaronontheweb marked this pull request as ready for review March 21, 2025 20:12
@Aaronontheweb Aaronontheweb merged commit cd077a1 into akkadotnet:v1.6 Mar 21, 2025
12 checks passed
@Aaronontheweb Aaronontheweb deleted the ReceiveActorHandlers-ordering-full-removal branch March 21, 2025 20:13
This was referenced Mar 21, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

akka.net v1.6 Akka.NET v1.6-related issues akka-actor akka-persistence AOT Ahead-of-Time (AOT) Compilation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aaronontheweb @mhbuck @Arkatufus