Skip to content

Commit e079ec7

Browse files
authored
Merge pull request #2015 from aksonov/4.0.0-beta.8
PR for beta.8
2 parents 9839c1d + 7c31ed9 commit e079ec7

File tree

14 files changed

+308
-107
lines changed

14 files changed

+308
-107
lines changed

.eslintrc.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,17 @@ module.exports = {
22
extends: 'airbnb',
33
plugins: [
44
'react',
5+
'jest'
56
],
7+
env: {
8+
"jest/globals": true
9+
},
610
parser: 'babel-eslint',
711
rules: {
12+
"jest/no-disabled-tests": "warn",
13+
"jest/no-focused-tests": "error",
14+
"jest/no-identical-title": "error",
15+
"jest/valid-expect": "error",
816
'react/forbid-prop-types': 0,
917
'no-console': 0,
1018
'new-cap': 0,

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ before_script:
3030
- if [ $TEST_SUITE = example-jest ]; then rm -rf Example/node_modules/react-native-router-flux/Example; fi
3131
- if [ $TEST_SUITE = example-jest ]; then cp -r src/ Example/node_modules/react-native-router-flux/src/; fi
3232
script:
33-
- if [ $TEST_SUITE = eslint ]; then node node_modules/eslint/bin/eslint index.js src/ test/; fi
33+
- if [ $TEST_SUITE = eslint ]; then node node_modules/.bin/eslint index.js src/ _tests__/; fi
3434
- if [ $TEST_SUITE = lib-test ]; then yarn test; fi
3535
- if [ $TEST_SUITE = example-jest ]; then cd Example && yarn run jest && cd ..; fi
3636
before_cache:

Example/Example.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,17 +50,17 @@ class Example extends Component {
5050
render() {
5151
return (
5252
<Router createReducer={reducerCreate}>
53-
<Scene key="lightbox" lightbox>
53+
<Scene key="lightbox" lightbox leftButtonTextStyle={{ color: 'green' }} backButtonTextStyle={{ color:'red' }} >
5454
<Scene key="modal" modal hideNavBar>
5555
<Scene key="drawer" drawer contentComponent={TabView} >
5656
<Scene key="root" hideNavBar hideTabBar>
5757
<Scene key="echo" back clone component={EchoView} getTitle={({navigation}) => navigation.state.key}/>
5858
<Scene key="register" back>
59-
<Scene key="_register" component={Register} title="Register"/>
60-
<Scene key="register2" component={Register} title="Register2"/>
61-
<Scene key="home" component={Home} title="Replace" type='replace'/>
59+
<Scene key="_register" component={Register} title="Register" />
60+
<Scene key="register2" component={Register} title="Register2" />
61+
<Scene key="home" component={Home} title="Replace" type='replace' />
6262
</Scene>
63-
<Scene key="launch" component={Launch} title="Launch" initial/>
63+
<Scene key="launch" component={Launch} title="Launch" initial />
6464
<Scene
6565
key="tabbar"
6666
gestureEnabled={false}
@@ -114,12 +114,13 @@ class Example extends Component {
114114
</Scene>
115115
</Scene>
116116
</Scene>
117-
<Scene key="login">
117+
<Scene key="login" >
118118
<Scene key="loginModal" component={Login} title="Login" leftTitle="Cancel" onLeft={Actions.pop}/>
119119
<Scene
120120
key="loginModal2"
121121
component={Login2}
122122
title="Login2"
123+
backTitle="Back"
123124
panHandlers={null}
124125
duration={1}
125126
/>

Example/components/Launch.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ const styles = StyleSheet.create({
1616

1717
class Launch extends React.Component {
1818
render(){
19+
console.log("Launch RENDER");
1920
return (
2021
<View {...this.props} style={styles.container}>
2122
<Text>Launch page</Text>

Example/components/Login.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,24 @@ const styles = StyleSheet.create({
2323
});
2424

2525
export default class extends React.Component {
26+
componentDidMount() {
27+
Actions.refresh({
28+
title: 'Login!',
29+
rightTitle: 'rightTitle',
30+
onRight: () => {},
31+
});
32+
}
2633
render() {
2734
const title = this.props.title || 'No Title';
2835
const data = this.props.data || 'No Data';
36+
console.log("Login RENDER");
2937
return (
3038
<View style={[styles.container, this.props.style]}>
3139
<Text>Login page 1</Text>
3240
<Text>Title: {title}</Text>
3341
<Text>Data: {data}</Text>
3442
<Button onPress={() => Actions.loginModal2({data: "Custom data2", title: "Custom title2"})}>Login 2</Button>
35-
<Button onPress={() => Actions.refresh({title: "Changed title"})}>Change title</Button>
43+
<Button onPress={() => Actions.refresh({title: "Changed title", data: "Changed data"})}>Change title</Button>
3644
<Button onPress={Actions.pop}>Back</Button>
3745
</View>
3846
);

Example/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@
88
},
99
"dependencies": {
1010
"autobind-decorator": "^1.4.1",
11-
"mobx": "^3.1.16",
11+
"mobx": "^3.2.1",
1212
"mobx-react": "^4.2.1",
13+
"react": "16.0.0-alpha.6",
14+
"react-native": "0.44.0",
1315
"react-native-button": "^2.0.0",
14-
"react-navigation": "^1.0.0-beta.11",
1516
"react-native-router-flux": "^4.0.0-beta.7",
16-
"react": "16.0.0-alpha.6",
17-
"react-native": "0.44.0"
17+
"react-navigation": "^1.0.0-beta.11"
1818
},
1919
"devDependencies": {
2020
"babel-jest": "20.0.3",

0 commit comments

Comments
 (0)