Skip to content

Making the settings configurable #52

@ZvonimirMatic

Description

@ZvonimirMatic

I think the settings could be more configurable. I don't see the reason for only one constructor with required parameters. In my opinion most of the properties should be able to be set publicly with some default values. This would allow for appsettings.json configuration. Also it would be very useful to be able to control certain parameters such as SqliteDbPath.

The interface ISejilSettings seems unnecessary.

If you want I can help you with the changes, but I would like your opinion first.

Other than that, it' a great library you've built!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions