/control/allocation now return stopped vm

Update /control/allocation endpoint to return the list of VM it stopped
this allow for better feedback

Author: olethanh

src/aleph/vm/orchestrator/views/__init__.py

@@ -429,6 +429,7 @@ def authenticate_api_request(request: web.Request) -> bool:
 
 async def update_allocations(request: web.Request):
     """Main entry for the start of persistence VM and instance, called by the Scheduler,
+    POST /control/allocations
 
 
     auth via the SETTINGS.ALLOCATION_TOKEN_HASH  sent in header X-Auth-Signature.
@@ -450,8 +451,10 @@ async def update_allocations(request: web.Request):
     pool: VmPool = request.app["vm_pool"]
 
     async with allocation_lock:
+        logger.debug("Got allocation_lock, updating allocations")
         # First, free resources from persistent programs and instances that are not scheduled anymore.
         allocations = allocation.persistent_vms | allocation.instances
+        stopped_vms = []
         # Make a copy since the pool is modified
         for execution in list(pool.get_persistent_executions()):
             if (
@@ -465,6 +468,7 @@ async def update_allocations(request: web.Request):
                 logger.info("Stopping %s %s", vm_type, execution.vm_hash)
                 await pool.stop_vm(execution.vm_hash)
                 pool.forget_vm(execution.vm_hash)
+                stopped_vms.append(execution.vm_hash)
 
         # Second start persistent VMs and instances sequentially to limit resource usage.
 
@@ -531,6 +535,7 @@ async def update_allocations(request: web.Request):
                 "success": not failing,
                 "successful": list(successful),
                 "failing": list(failing),
+                "stopped": list(stopped_vms),
                 "errors": {vm_hash: repr(error) for vm_hash, error in scheduling_errors.items()},
             },
             status=status_code,