This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Fixes a bug affecting resizing of cells with varying and dynamic cell heights. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… layoutSubviews method to PXListViewCell; added reloadRowAtIndex method; removed PXLog log messages
|
Added another commit. This is related to the layoutSubviews method that UITableViewCell implements. I've added initial rudimentary support to PXListView for it. I also removed the calls to PXLog since it was triggering on the DEBUG define which is commonly used by developers but it's symbol was not being found by the linker. So this might cause issues for people who want to use the code with little or no modification. |
…g active after dropping a cell"
|
More changes for dragging and dropping. The crash fix is an important one... you're not removing yourself as an observer on NSNotificationCenter, which is causing crashes. At the very least you should definitely take that pull. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug where cells with different heights in the same table would not properly update when the window was resized or scrolled. Additionally, fixes a bug where live resizing would not resize the cells when the table is embedded in an NSSplitView.