fix(mmc): explicitly check operators precedence

Yann-lms · Yann-lms · commit 14cda5168de4 · 2022-12-07T14:16:48.000+01:00
This corrects the MISRA violation C2012-12.1:
The precedence of operators within expressions should be made explicit
While at it put the test on one line.

Signed-off-by: Yann Gautier &lt;yann.gautier@st.com&gt;
Change-Id: Id19231faaf033c1e7dbe703690e0dddc7aa8f346
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
@@ -780,8 +780,7 @@ int mmc_part_switch_current_boot(void)
 	unsigned char current_boot_part = mmc_current_boot_part();
 	int ret;
 
-	if (current_boot_part != 1U &&
-	    current_boot_part != 2U) {
+	if ((current_boot_part != 1U) && (current_boot_part != 2U)) {
 		ERROR("Got unexpected value for active boot partition, %u\n", current_boot_part);
 		return -EIO;
 	}

Original file line number	Diff line number	Diff line change
`@@ -780,8 +780,7 @@ int mmc_part_switch_current_boot(void)`
`780`	`780`	`unsigned char current_boot_part = mmc_current_boot_part();`
`781`	`781`	`int ret;`
`782`	`782`
`783`		`- if (current_boot_part != 1U &&`
`784`		`- current_boot_part != 2U) {`
	`783`	`+ if ((current_boot_part != 1U) && (current_boot_part != 2U)) {`
`785`	`784`	`ERROR("Got unexpected value for active boot partition, %u\n", current_boot_part);`
`786`	`785`	`return -EIO;`
`787`	`786`	`}`