Skip to content

Commit 60719e4

Browse files
fix(plat/css): fix invalid redistributor poweroff
Commit 4d8c181 introduced an invalid redistributor power off where we turn off the redistributor without checking if the system power domain level is turning off, otherwise we can turn off a redistributor when other cores or clusters are sharing it, also if it does indeed needs powering off during suspend we do it twice. This change fixes this by checking on the system power state first then turning off the redistributor. Signed-off-by: Waleed Elmelegy <[email protected]> Change-Id: Id202bc2316ab7c516298fa33ea089ae2e221a933
1 parent 28a8efd commit 60719e4

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

plat/arm/css/common/css_pm.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,6 @@ static void css_power_down_common(const psci_power_state_t *target_state)
130130
/* Prevent interrupts from spuriously waking up this cpu */
131131
plat_arm_gic_cpuif_disable();
132132

133-
/* Turn redistributor off */
134-
plat_arm_gic_redistif_off();
135-
136133
/* Cluster is to be turned off, so disable coherency */
137134
if (CSS_CLUSTER_PWR_STATE(target_state) == ARM_LOCAL_STATE_OFF) {
138135
plat_arm_interconnect_exit_coherency();

0 commit comments

Comments
 (0)