Reconcile Transaction against Purchase Invoice return

[Nudelsalad]

Hey,
I noticed that I can not reconcile a Transaction against a return.

A return will be per erpnext default negative:

[0xD0M1M0]

Fix:

Add
Abs

banking/banking/klarna_kosma_integration/doctype/bank_reconciliation_tool_beta/bank_reconciliation_tool_beta.py

Line 16 in f404141

from frappe.query_builder.functions import Cast, Coalesce, Sum

Update
Abs(purchase_invoice.outstanding_amount).as_("paid_amount"),

banking/banking/klarna_kosma_integration/doctype/bank_reconciliation_tool_beta/bank_reconciliation_tool_beta.py

Line 1256 in f404141

purchase_invoice.outstanding_amount.as_("paid_amount"),

[Nudelsalad]

Hey @0xD0M1M0,

thanks for looking into it. How about a PR so it can be reviewed and merged by @barredterra? :)

[0xD0M1M0]

Hey @Nudelsalad ,
It was a series of fixes and especially the multi-currency reconciliation is tricky.
The two fixes are dependent on each other. There are some other features in the pipeline which need some of it.

[Nudelsalad]

Oh I see @0xD0M1M0 ,
massive thanks for your work, this is also something I need xD.