fix more issues with env and github url

Author: mama-samba-braima

.github/workflows/deploy.yml

@@ -28,7 +28,7 @@ jobs:
       - name: Send slack message with github commit url
         run: >
           curl -X POST -H 'Content-type: application/json'
-          --data '{"text":":rocket: Deployment started for commit: ${{ github.event.head_commit.message }} - https://${{ github.repository }}/commit/${{ github.sha }}"}' 
+          --data '{"text":":rocket: Deployment started for commit: ${{ github.event.head_commit.message }} - https://github.com/${{ github.repository }}/commit/${{ github.sha }}"}' 
           ${{ env.SLACK_WEBHOOK_URL }}
       - name: JDK
         if: ${{ github.event.inputs.build_number == '' }}
@@ -71,14 +71,14 @@ jobs:
         run: |
           curl -X POST -H 'Content-type: application/json' --data "{\"text\":\":hammer_and_wrench: Building and deploying $IMAGE to Docker Hub...\"}" ${{ env.SLACK_WEBHOOK_URL }}
           mvn -B -ntp clean verify jib:build -Ddocker.image.tag=$BUILD_NUMBER
-          curl -X POST -H 'Content-type: application/json' --data "{\"text\":\":white_check_mark: Successfully built and pushed $IMAGE to Docker Hub\"}" ${{ env.SLACK_WEBHOOK_URL }}
+          curl -X POST -H 'Content-type: application/json' --data "{\"text\":\":white_check_mark: Successfully built and pushed ${{ env.IMAGE }} to Docker Hub\"}" ${{ env.SLACK_WEBHOOK_URL }}
       - name: Setup SSH Agent
         uses: webfactory/[email protected]
         with:
           ssh-private-key: ${{ env.EC2_SSH_PRIVATE_KEY }}
       - name: SSH To EC2 and Deploy
         run: |
-          curl -X POST -H 'Content-type: application/json' --data '{"text":":cloud: Deploying $IMAGE to AWS EC2..."}' ${{ env.SLACK_WEBHOOK_URL }}
+          curl -X POST -H 'Content-type: application/json' --data '{"text":":cloud: Deploying ${{ env.IMAGE }} to AWS EC2..."}' ${{ env.SLACK_WEBHOOK_URL }}
           ssh -o StrictHostKeyChecking=no ec2-user@$EC2_PUBLIC_IP_ADDRESS << EOF
             cd ~
             sed -i 's|image: '"$DOCKER_USERNAME"'/'"$DOCKER_IMAGE_NAME"':.*$|image: '"$DOCKER_USERNAME"'/'"$DOCKER_IMAGE_NAME"':'"$BUILD_NUMBER"'|' docker-compose.yml
@@ -88,7 +88,7 @@ jobs:
             docker ps
             echo "$BUILD_NUMBER" > build-number.txt
           EOF
-          curl -X POST -H 'Content-type: application/json' --data "{\"text\":\":tada: Successfully deployed $IMAGE to AWS EC2\"}" ${{ env.SLACK_WEBHOOK_URL }}
+          curl -X POST -H 'Content-type: application/json' --data "{\"text\":\":tada: Successfully deployed ${{ env.IMAGE }} to AWS EC2\"}" ${{ env.SLACK_WEBHOOK_URL }}
       - name: Send slack message with status
         if: always()
         run: |