Get information about binaries in PeTar #1052
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Not ready for merging before the following is fixed:
|
rieder
commented
May 3, 2024
| *binary_companion = p->getBinaryPairID() - 1; | ||
| return 0; | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
This also needs to work with multiple workers, similar to other getters.
rieder
added
the
kind: feature request
Member
Author
|
@cournoyercloutierc have you been able to try this? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 365 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way of getting information about binary companions of particles in PeTar.
cc: @lwang-astro @cournoyercloutierc