[http] improve errors handling

Author: capcom6

android_sms_gateway/ahttp.py

@@ -1,4 +1,5 @@
 import abc
+from contextlib import suppress
 import typing as t
 
 from .errors import (
@@ -81,14 +82,13 @@ async def _process_response(self, response: aiohttp.ClientResponse) -> dict:
                     return {}
 
                 return await response.json()
+            except aiohttp.ContentTypeError:
+                return {}
             except aiohttp.ClientResponseError as e:
                 # Extract error message from response if available
                 error_data = {}
-                try:
+                with suppress(ValueError, aiohttp.ContentTypeError):
                     error_data = await response.json()
-                except ValueError:
-                    # Response is not JSON
-                    pass
 
                 # Use the error mapping to create appropriate exception
                 error_message = str(e) or "HTTP request failed"
@@ -188,15 +188,16 @@ async def __aexit__(self, exc_type, exc_val, exc_tb):
         async def _process_response(self, response: httpx.Response) -> dict:
             try:
                 response.raise_for_status()
-                if response.status_code == 204:
+                if response.status_code == 204 or not response.content:
                     return {}
 
                 return response.json()
             except httpx.HTTPStatusError as e:
                 # Extract error message from response if available
                 error_data = {}
                 try:
-                    error_data = response.json()
+                    if response.content:
+                        error_data = response.json()
                 except ValueError:
                     # Response is not JSON
                     pass

android_sms_gateway/http.py

@@ -133,15 +133,16 @@ def patch(
         def _process_response(self, response: requests.Response) -> dict:
             try:
                 response.raise_for_status()
-                if response.status_code == 204:
+                if response.status_code == 204 or not response.content:
                     return {}
 
                 return response.json()
             except requests.exceptions.HTTPError as e:
                 # Extract error message from response if available
                 error_data = {}
                 try:
-                    error_data = response.json()
+                    if response.content:
+                        error_data = response.json()
                 except ValueError:
                     # Response is not JSON
                     pass
@@ -181,15 +182,16 @@ def __exit__(self, exc_type, exc_val, exc_tb):
         def _process_response(self, response: httpx.Response) -> dict:
             try:
                 response.raise_for_status()
-                if response.status_code == 204:
+                if response.status_code == 204 or not response.content:
                     return {}
 
                 return response.json()
             except httpx.HTTPStatusError as e:
                 # Extract error message from response if available
                 error_data = {}
                 try:
-                    error_data = response.json()
+                    if response.content:
+                        error_data = response.json()
                 except ValueError:
                     # Response is not JSON
                     pass