pst mining: clear toast when file might be corrupt (#2602)

* return 422 'Failed to parse PST file'

* Update error-handler.ts

* fix typo

* prettier

Author: J43fura

backend/src/controllers/mining.controller.ts

@@ -451,7 +451,6 @@ export default function initializeMiningController(
           data: fileMiningTask
         });
       } catch (err) {
-        res.status(500);
         return next(err);
       }
     },
@@ -514,7 +513,13 @@ export default function initializeMiningController(
           return res.sendStatus(409);
         }
 
-        res.status(500);
+        if (
+          err instanceof Error &&
+          err.message === 'Failed to parse PST file'
+        ) {
+          return res.status(422).json({ message: err.message });
+        }
+
         return next(err);
       }
     },

backend/src/services/email-fetching/pst.ts

@@ -44,6 +44,15 @@ class PSTFetcherClient {
         error,
         payload
       });
+      if (
+        axios.isAxiosError(error) &&
+        error.response &&
+        error.response.status === 422 &&
+        error.response.data.message === 'Failed to parse PST file'
+      ) {
+        throw new Error(error.response.data.message);
+      }
+
       throw error;
     }
   }

backend/src/services/tasks-manager/TasksManagerPST.ts

@@ -267,7 +267,7 @@ export default class TasksManagerPST {
         logger.error(`Failed to start fetching task with id: ${miningId}`, {
           error
         });
-        throw new Error('Failed to start fetching');
+        throw error;
       }
 
       this.redisSubscriber.subscribe(miningId, (err) => {

frontend/src/plugins/error-handler.ts

@@ -17,7 +17,8 @@ const ERROR_STATUS_MESSAGES: ErrorStatusMessages = {
   400: 'Oops! Something went wrong. Please double-check your input and try again.',
   401: "Sorry, you're not authorized. Please log in and try again.",
   403: 'Access denied. Please contact support if you need assistance.',
-  404: "what you're looking for couldn't be found.",
+  404: "What you're looking for couldn't be found.",
+  422: "We couldn't process this file, Please try another one.",
   500: 'Something went wrong on our end. Please try again later.',
   502: 'Our server is having issues. Please try again later.',
   503: 'Service is temporarily unavailable. Please check your connection or try again later.',
@@ -53,6 +54,9 @@ function networkErrorMessage(err: unknown) {
 
 function otherErrorMessages(err: unknown) {
   if (isFetchError(err) && err.response) {
+    if (err.response.status === 422) {
+      return ERROR_STATUS_MESSAGES[err.response.status];
+    }
     return (
       err.response._data.message ?? ERROR_STATUS_MESSAGES[err.response.status]
     );

micro-services/emails-fetcher/src/api.ts

@@ -338,6 +338,12 @@ apiRoutes.post(
       });
     } catch (err) {
       logger.error('Failed to start fetching', err);
+      if (
+        err instanceof Error &&
+        err.stack?.includes('Failed to parse PST file')
+      ) {
+        return res.status(422).json({ message: 'Failed to parse PST file' });
+      }
       if (
         err instanceof Error &&
         err.message.toLowerCase().startsWith('invalid credentials')
@@ -352,10 +358,8 @@ apiRoutes.post(
         return res.sendStatus(409);
       }
 
-      const newError = generateErrorObjectFromImapError(err);
-
       res.status(500);
-      return next(new Error(newError.message));
+      return next(err);
     }
   }
 );

micro-services/emails-fetcher/src/services/pst/PSTEmailsFetcher.ts

@@ -450,7 +450,11 @@ export default class PSTEmailsFetcher {
 
     const writeStream = fs.createWriteStream(this.localPstFilePath);
     await pipeline(res.body, writeStream);
-    this.pstFile = new PSTFile(this.localPstFilePath);
+    try {
+      this.pstFile = new PSTFile(this.localPstFilePath);
+    } catch (err) {
+      throw new Error('Failed to parse PST file', { cause: err });
+    }
   }
 
   /**