fix: use public campaign links and configurable compliance footer (#2624)

* fix: use public campaign links and configurable compliance footer

* remove redundant undefined

---------

Co-authored-by: Malek Salem <malek.salem.14@gmail.com>

Author: baderdean

frontend/.env.example

@@ -4,6 +4,7 @@ POSTHOG_INSTANCE_ADDRESS=
 AVERAGE_EXTRACTION_RATE=50
 SAAS_SUPABASE_PROJECT_URL=http://127.0.0.1:54321
 SAAS_SUPABASE_ANON_KEY=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJzdXBhYmFzZS1kZW1vIiwicm9sZSI6ImFub24iLCJleHAiOjE5ODM4MTI5OTZ9.CRXP1A7WOeoJeXxjNni43kdQwgnWNReilDMblYTn_I0
+CAMPAIGN_COMPLIANCE_FOOTER=
 IMAGE_REVERSE_PROXY=
 NOMINATIM_URL=https://nominatim.openstreetmap.org/search
 

frontend/nuxt.config.ts

@@ -56,6 +56,7 @@ export default defineNuxtConfig({
       // Supabase saas
       SAAS_SUPABASE_PROJECT_URL: process.env.SAAS_SUPABASE_PROJECT_URL,
       SAAS_SUPABASE_ANON_KEY: process.env.SAAS_SUPABASE_ANON_KEY,
+      CAMPAIGN_COMPLIANCE_FOOTER: process.env.CAMPAIGN_COMPLIANCE_FOOTER,
       IMAGE_REVERSE_PROXY: process.env.IMAGE_REVERSE_PROXY,
       // Nominatim
       NOMINATIM_URL: process.env.NOMINATIM_URL,

frontend/src/components/campaigns/CampaignComposerDialog.vue

@@ -365,6 +365,7 @@ const dialogHeader = computed(() =>
 
 const availableSenderEmails = ref<string[]>([]);
 const fallbackSenderEmail = ref('');
+const runtimeConfig = useRuntimeConfig();
 
 const DEFAULT_PROJECT_URL = 'https://example.com/project';
 const DEFAULT_PROJECT_IMAGE_SRC =
@@ -397,6 +398,7 @@ const DEFAULT_BODY_TEXT = () => {
 };
 
 const DEFAULT_FOOTER_TEXT = () =>
+  String(runtimeConfig.public.CAMPAIGN_COMPLIANCE_FOOTER || '').trim() ||
   t('default_footer_template', {
     ownerEmailToken: '{{ownerEmail}}',
     unsubscribeToken: '{{unsubscribeUrl}}',

frontend/src/pages/campaigns.vue

@@ -473,7 +473,7 @@ onBeforeUnmount(() => {
   },
   "fr": {
     "campaigns": "Campagnes",
-    "refresh": "Rafraichir",
+    "refresh": "Rafraîchir",
     "no_campaigns": "Aucune campagne",
     "delivery": "Livraison",
     "opens": "Ouvertures",
@@ -489,11 +489,11 @@ onBeforeUnmount(() => {
     "top_clicked_links": "Liens les plus cliqués",
     "top_clicked_links_tooltip": "Les clics uniques sont comptés une fois par destinataire et par lien.",
     "unique_clicks_count": "{count} clics uniques",
-    "campaign_sent": "Campagne envoyee",
-    "campaign_sent_detail": "Votre campagne a ete entierement envoyee.",
+    "campaign_sent": "Campagne envoyée",
+    "campaign_sent_detail": "Votre campagne a été entièrement envoyée.",
     "campaign_failed": "Campagne échouée",
     "campaign_failed_detail": "La campagne n'a pu envoyer aucun email. Vérifiez la configuration d'expédition puis réessayez.",
-    "see_results": "Voir les resultats",
+    "see_results": "Voir les résultats",
     "load_failed": "Impossible de charger les campagnes",
     "cancel": "Annuler",
     "stop_campaign": "Stopper",

supabase/functions/.env.dev

@@ -8,7 +8,8 @@ SMTP_HOST=smtp.example.email
 SMTP_PORT=587
 SMTP_USER=your-secret-smtp-username
 SMTP_PASS=your-secret-smtp-password
+campaign_compliance_footer=
 
 LOGO_URL="https://db.leadminer.io/storage/v1/object/public/templates/LogoWithIcon.png"
 FRONTEND_HOST="http://localhost:8082"
-SERVER_ENDPOINT =  http://localhost:8081    # ( REQUIRED ) URL of the Backend server.
+SERVER_ENDPOINT =  http://localhost:8081    # ( REQUIRED ) URL of the Backend server.

supabase/functions/.env.prod

@@ -7,7 +7,8 @@ SMTP_HOST=
 SMTP_PORT=
 SMTP_USER=
 SMTP_PASS=
+campaign_compliance_footer=
 
 LOGO_URL="https://db.leadminer.io/storage/v1/object/public/templates/LogoWithIcon.png"
 FRONTEND_HOST="https://app.leadminer.io"
-SERVER_ENDPOINT =  http://localhost:8081    # ( REQUIRED ) URL of the Backend server.
+SERVER_ENDPOINT =  http://localhost:8081    # ( REQUIRED ) URL of the Backend server.

supabase/functions/_shared/url.test.ts

@@ -0,0 +1,22 @@
+import {
+  assertEquals,
+  assertThrows,
+} from "https://deno.land/std@0.224.0/assert/mod.ts";
+import { resolvePublicBaseUrl } from "./url.ts";
+
+Deno.test("resolvePublicBaseUrl prefers explicit public URL", () => {
+  const value = resolvePublicBaseUrl(
+    "https://db-qa.domain.io/",
+    "http://kong:8000",
+  );
+  assertEquals(value, "https://db-qa.domain.io");
+});
+
+Deno.test("resolvePublicBaseUrl falls back to secondary URL", () => {
+  const value = resolvePublicBaseUrl(undefined, "http://localhost:54321/");
+  assertEquals(value, "http://localhost:54321");
+});
+
+Deno.test("resolvePublicBaseUrl throws when both values are missing", () => {
+  assertThrows(() => resolvePublicBaseUrl());
+});

supabase/functions/_shared/url.ts

@@ -0,0 +1,14 @@
+function normalizeBaseUrl(url: string): string {
+  return url.replace(/\/+$/, "");
+}
+
+export function resolvePublicBaseUrl(
+  explicitPublicUrl?: string,
+  fallbackUrl?: string,
+): string {
+  const candidate = (explicitPublicUrl || fallbackUrl || "").trim();
+  if (!candidate) {
+    throw new Error("Missing public base URL");
+  }
+  return normalizeBaseUrl(candidate);
+}

supabase/functions/email-campaigns/index.ts

@@ -3,14 +3,18 @@ import IMAPSettingsDetector from "npm:@ankaboot.io/imap-autoconfig";
 import corsHeaders from "../_shared/cors.ts";
 import { verifyServiceRole } from "../_shared/middlewares.ts";
 import { createSupabaseAdmin, createSupabaseClient } from "../_shared/supabase.ts";
+import { resolvePublicBaseUrl } from "../_shared/url.ts";
 import { sendEmail, verifyTransport } from "./email.ts";
 
 const functionName = "email-campaigns";
 const app = new Hono().basePath(`/${functionName}`);
 
 const SUPABASE_URL = Deno.env.get("SUPABASE_URL") as string;
+const LEADMINER_PROJECT_URL = Deno.env.get("LEADMINER_PROJECT_URL");
 const SUPABASE_SERVICE_ROLE_KEY = Deno.env.get("SUPABASE_SERVICE_ROLE_KEY") as string;
 const LEADMINER_HASH_SECRET = Deno.env.get("LEADMINER_HASH_SECRET") as string;
+const CAMPAIGN_COMPLIANCE_FOOTER = (Deno.env.get("campaign_compliance_footer") || Deno.env.get("CAMPAIGN_COMPLIANCE_FOOTER") || "").trim();
+const PUBLIC_CAMPAIGN_BASE_URL = resolvePublicBaseUrl(LEADMINER_PROJECT_URL || undefined, SUPABASE_URL || undefined);
 const SMTP_USER = (Deno.env.get("SMTP_USER") || "").trim().toLowerCase();
 const DEFAULT_SENDER_DAILY_LIMIT = 1000;
 const MAX_SENDER_DAILY_LIMIT = 2000;
@@ -274,7 +278,7 @@ function toHtmlFromText(template: string): string {
 }
 
 function buildUnsubscribeUrl(token: string): string {
-  return `${SUPABASE_URL}/functions/v1/email-campaigns/unsubscribe/${token}`;
+  return `${PUBLIC_CAMPAIGN_BASE_URL}/functions/v1/email-campaigns/unsubscribe/${token}`;
 }
 
 async function triggerCampaignProcessorFromEdge() {
@@ -293,6 +297,9 @@ async function triggerCampaignProcessorFromEdge() {
 }
 
 function defaultFooterTemplate(ownerEmail: string): string {
+  if (CAMPAIGN_COMPLIANCE_FOOTER) {
+    return CAMPAIGN_COMPLIANCE_FOOTER;
+  }
   return `${COMPLIANCE_SEPARATOR}\n\nYou received this email because ${ownerEmail} used leadminer.io to extract contacts from their mailbox. Try https://leadminer.io yourself.\n\n${UNSUBSCRIBE_TEXT_SUFFIX}: {{unsubscribeUrl}}`;
 }
 
@@ -742,13 +749,13 @@ async function injectTrackers(
       }
 
       const token = await recordClickLink(supabaseAdmin, campaignId, recipientId, originalUrl);
-      const trackedUrl = `${SUPABASE_URL}/functions/v1/email-campaigns/track/click/${token}`;
+      const trackedUrl = `${PUBLIC_CAMPAIGN_BASE_URL}/functions/v1/email-campaigns/track/click/${token}`;
       updatedHtml = updatedHtml.replace(`href="${originalUrl}"`, `href="${trackedUrl}"`);
     }
   }
 
   if (trackOpen) {
-    const pixelUrl = `${SUPABASE_URL}/functions/v1/email-campaigns/track/open/${openToken}`;
+    const pixelUrl = `${PUBLIC_CAMPAIGN_BASE_URL}/functions/v1/email-campaigns/track/open/${openToken}`;
     updatedHtml += `<img src="${pixelUrl}" alt="" width="1" height="1" style="display:none" />`;
   }