feat(converter): fix issue with target_version wrongly initialised

Author: muffoltz

converter/converter/cisu/cisu_converter.py

@@ -13,7 +13,6 @@
 
 class CISUConverterV3:
     # Todo: revert change when all editors use the new CISU nomenclature or are in V3 or above
-    target_version=""
     def __init__(self, target_version: str):
         self.target_version = target_version
 
@@ -67,7 +66,7 @@ def __init__(self, target_version: str):
     DEFAULT_WHATS_HAPPEN = {"code": "C11.06.00", "label":"Autre nature de fait"}
 
     @classmethod
-    def from_cisu(cls, input_json: Dict[str, Any]) -> Dict[str, Any]:
+    def from_cisu(cls, input_json: Dict[str, Any], target_version: str) -> Dict[str, Any]:
         """
         Convert from CISU to Health format
 
@@ -148,8 +147,7 @@ def add_object_to_medical_notes(json_data: Dict[str, Any], note_text: str, sende
 
         # - Updates
         output_use_case_json['owner'] = get_recipient(input_json)
-
-        if cls.target_version != Constants.V3_VERSION:
+        if target_version != Constants.V3_VERSION:
             # /!\ it must be done before copying qualification
             update_health_motive_code(output_use_case_json, True)
 

converter/converter/conversion_strategy/cisu_conversion_strategy.py

@@ -30,7 +30,7 @@ def cisu_conversion_strategy(edxl_json, source_version, target_version):
         if source_version != MAINTAINED_CISU_VERSION:
             raise ValueError(f"Unknown source version {source_version}. Must be: {MAINTAINED_CISU_VERSION}")
 
-        rc_json_message = CISUConverterV3(target_version).from_cisu(edxl_json)
+        rc_json_message = CISUConverterV3.from_cisu(edxl_json, target_version)
         return health_conversion_strategy(rc_json_message, MAINTAINED_CISU_VERSION, target_version)
     else:
         raise ValueError('Invalid direction parameter')