Fix quota project id review comments: form widget, docstrings, anon check, error messages, test boundaries

Author: Ankurdeewan

providers/google/docs/connections/gcp.rst

@@ -127,7 +127,7 @@ Quota Project ID (optional)
 
 The Google Cloud project ID to use for API quota and billing purposes. This is useful
 when using a shared service account but want to attribute quota/billing to a different
-project. If not specified, the default project from the connection is used. Must be a
+project. If not specified, no separate quota project is configured on the credentials and Google Cloud's default behavior applies. Must be a
 valid GCP project ID (lowercase letters, digits, hyphens, 6–30 characters, starting
 with a letter).
 
@@ -418,5 +418,5 @@ Examples
 
 **Examples**
 
-See the example DAG: ``airflow/providers/google/cloud/example_dags/example_quota_project.py``
+See the example DAG: ``tests/system/providers/google/common/example_quota_project_system.py``
 

providers/google/src/airflow/providers/google/common/hooks/base_google.py

@@ -262,6 +262,9 @@ def get_connection_form_widgets(cls) -> dict[str, Any]:
             "is_anonymous": BooleanField(
                 lazy_gettext("Anonymous credentials (ignores all other settings)"), default=False
             ),
+            "quota_project_id": StringField(
+                lazy_gettext("Quota Project ID"), widget=BS3TextFieldWidget()
+            ),
         }
 
     @classmethod
@@ -291,7 +294,7 @@ def __init__(
         :param impersonation_chain: Optional service account to impersonate using short-term
             credentials.
         :param quota_project_id: Optional Project ID to use for quota/billing purposes.
-            If None, the Project ID from the GCP connection is used.
+            If None, no separate quota project is configured and the default behavior of the credentials is used.
         :param kwargs: Additional arguments to pass to parent constructor.
         """
         super().__init__(**kwargs)
@@ -356,7 +359,7 @@ def get_credentials_and_project_id(self) -> tuple[Credentials, str | None]:
 
         # Apply quota project before caching credentials
         quota_project = self.quota_project_id or self._get_field("quota_project_id")
-        if quota_project:
+        if quota_project and not is_anonymous:
             self._validate_quota_project(quota_project)
             if not hasattr(credentials, "with_quota_project"):
                 raise ValueError(
@@ -391,8 +394,7 @@ def _validate_quota_project(self, quota_project: str) -> None:
         if not is_valid_gcp_project_id(quota_project):
             raise ValueError(
                 f"Invalid quota_project_id '{quota_project}'. "
-                "Project IDs must start with a lowercase letter and can contain "
-                "only lowercase letters and digits."
+                "Project IDs must be 6-30 characters long, start with a lowercase letter, and can contain only lowercase letters, digits, and hyphens."
             )
 
     def get_credentials(self) -> Credentials:

providers/google/tests/unit/google/common/hooks/test_base_google.py

@@ -585,11 +585,10 @@ def test_quota_project_invalid_format(self):
         invalid_ids = [
             "UPPERCASE",  # Must be lowercase
             "special@chars",  # Invalid characters
-            "a",  # Too short
-            "a" * 31,  # Too long
+            "ab-cd",  # Too short
+            "a" + "b" * 30,  # Too long
             "1starts-with-number",  # Must start with letter
-            "",  # Empty string
-            None,  # None value
+            "", #Empty-String
         ]
 
         for invalid_id in invalid_ids: