Skip to content

Commit 93f34b3

Browse files
authored
Fix release documentation for Airflow-CTL PMC check (#62483)
1 parent 92954d8 commit 93f34b3

File tree

4 files changed

+14
-9
lines changed

4 files changed

+14
-9
lines changed

dev/README_RELEASE_AIRFLOW.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -886,11 +886,14 @@ present in SVN. This command may also help with verifying installation of the pa
886886
breeze release-management check-release-files airflow --version ${VERSION_RC}
887887
```
888888
889+
You will see commands that you can execute to check installation of the distributions in containers.
889890
890891
```shell script
891892
breeze release-management check-release-files task-sdk --version ${TASK_SDK_VERSION_RC}
892893
```
893894
895+
You will see commands that you can execute to check installation of the distributions in containers.
896+
894897
## Licence check
895898
896899
This can be done with the Apache RAT tool.

dev/README_RELEASE_AIRFLOWCTL.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,7 @@ present in SVN. This command may also help with verifying installation of the pa
539539
breeze release-management check-release-files airflow-ctl --version ${VERSION_RC}
540540
```
541541

542+
You will see commands that you can execute to check installation of the distributions in containers.
542543

543544
### Licence check
544545

dev/README_RELEASE_PYTHON_CLIENT.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -451,10 +451,7 @@ present in SVN. This command may also help with verifying installation of the pa
451451
breeze release-management check-release-files python-client --version ${VERSION_RC}
452452
```
453453

454-
You can also follow the docker check that installs the distribution in a docker container and verifies
455-
that the package can be installed and imported correctly and print it's version. The command above prints
456-
instructions on how to do that.
457-
454+
You will see commands that you can execute to check installation of the distributions in containers.
458455

459456
### Licence check
460457

dev/breeze/src/airflow_breeze/utils/check_release_files.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,15 @@ def create_docker(txt: str, output_file: Path, release_type: str):
8989

9090
console = get_console()
9191
console.print("\n[bold]To check installation run:[/bold]")
92-
command = (
93-
'--entrypoint "airflow" local/airflow info'
94-
if release_type != "python-client"
95-
else '--entrypoint "bash" local/airflow "-c" "python -c \'import airflow_client.client; print(airflow_client.client.__version__)\'"'
96-
)
92+
if release_type == "python-client":
93+
command = (
94+
'--entrypoint "bash" local/airflow "-c" "python -c '
95+
"'import airflow_client.client; print(airflow_client.client.__version__)'\""
96+
)
97+
elif release_type == "airflow-ctl":
98+
command = '--entrypoint "airflowctl" local/airflow --help'
99+
else:
100+
command = '--entrypoint "airflow" local/airflow info'
97101
console.print(
98102
f"""\
99103
docker build -f {output_file} --tag local/airflow .

0 commit comments

Comments
 (0)