Clean up

Author: jhrotko

vector/src/main/codegen/templates/DenseUnionVector.java

@@ -707,7 +707,6 @@ public ValueVector getTo() {
     public void copyValueSafe(int from, int to) {
       this.to.copyFrom(from, to, DenseUnionVector.this);
     }
-
   }
 
   @Override

vector/src/main/codegen/templates/UnionVector.java

@@ -620,7 +620,6 @@ public ValueVector getTo() {
     public void copyValueSafe(int from, int to) {
       this.to.copyFrom(from, to, UnionVector.this);
     }
-
   }
 
   @Override

vector/src/main/java/org/apache/arrow/vector/complex/FixedSizeListVector.java

@@ -652,10 +652,10 @@ public ValueVector getTo() {
 
     @Override
     public void copyValueSafe(int fromIndex, int toIndex) {
-      while (toIndex >= this.to.getValueCapacity()) {
-        this.to.reAlloc();
+      while (toIndex >= to.getValueCapacity()) {
+        to.reAlloc();
       }
-      BitVectorHelper.setValidityBit(this.to.validityBuffer, toIndex, isSet(fromIndex));
+      BitVectorHelper.setValidityBit(to.validityBuffer, toIndex, isSet(fromIndex));
       int fromOffset = fromIndex * listSize;
       int toOffset = toIndex * listSize;
       for (int i = 0; i < listSize; i++) {

vector/src/main/java/org/apache/arrow/vector/complex/StructVector.java

@@ -292,7 +292,10 @@ public void transfer() {
 
     @Override
     public void copyValueSafe(int fromIndex, int toIndex) {
-      reallocateTargetValidityBuffer(fromIndex, toIndex);
+      while (toIndex >= this.target.getValidityBufferValueCapacity()) {
+        target.reallocValidityBuffer();
+      }
+      BitVectorHelper.setValidityBit(target.validityBuffer, toIndex, isSet(fromIndex));
       super.copyValueSafe(fromIndex, toIndex);
     }
 
@@ -308,13 +311,6 @@ public void splitAndTransfer(int startIndex, int length) {
       splitAndTransferValidityBuffer(startIndex, length, target);
       super.splitAndTransfer(startIndex, length);
     }
-
-    private void reallocateTargetValidityBuffer(int fromIndex, int toIndex) {
-      while (toIndex >= this.target.getValidityBufferValueCapacity()) {
-        target.reallocValidityBuffer();
-      }
-      BitVectorHelper.setValidityBit(target.validityBuffer, toIndex, isSet(fromIndex));
-    }
   }
 
   /*

vector/src/main/java/org/apache/arrow/vector/complex/reader/FieldReader.java

@@ -16,7 +16,6 @@
  */
 package org.apache.arrow.vector.complex.reader;
 
-// import org.apache.arrow.vector.complex.reader.BaseReader.ExtensionReader;
 import org.apache.arrow.vector.complex.reader.BaseReader.ListReader;
 import org.apache.arrow.vector.complex.reader.BaseReader.MapReader;
 import org.apache.arrow.vector.complex.reader.BaseReader.RepeatedListReader;