-
Notifications
You must be signed in to change notification settings - Fork 1k
WIP: Special case apply_bitwise_*_op operation when buffers are u64 aligned
#8835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a581f4d to
5020953
Compare
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
My analysis of the results is that there are no obvious changes in performance |
Which issue does this PR close?
Rationale for this change
Add a special case for u64 (word aligned) buffers in
apply_bitwise_*_opoperationsI have been thinking (dreaming?) about this since the initial PR from @ruluvaton (see #8619 (comment))
If this shows reasonable performance improvements I will polish this up
What changes are included in this PR?
Add special case for
apply_bitwise_*_opAre these changes tested?
Functionally covered by existing tests.
I will also run benchmarks on this
Are there any user-facing changes?
TBD