feat: use getComputedStyle for setBackgroundColor

Author: erisu

cordova-js-src/plugin/android/statusbar.js

@@ -54,16 +54,31 @@ Object.defineProperty(statusBar, 'setBackgroundColor', {
     enumerable: false,
     writable: false,
     value: function (value) {
-        // Confirm if value is a valid hex code is before passing to native-side
-        if (!(/^#(?:[0-9a-fA-F]{6}|[0-9a-fA-F]{8})$/.test(value))) {
-            console.error('Invalid color hex code. Valid format: #RRGGBB or #AARRGGBB');
+        var script = document.querySelector('script[src$="cordova.js"]');
+        script.style.color = value;
+        var rgbStr = window.getComputedStyle(script).getPropertyValue('color');
+
+        if (!rgbStr.match(/^rgb/)) { return; }
+
+        var rgbVals = rgbStr.match(/\d+/g).map(function (v) { return parseInt(v, 10); });
+
+        if (rgbVals.length < 3) {
             return;
+        } else if (rgbVals.length === 3) {
+            rgbVals = [255].concat(rgbVals);
         }
 
+        const padRgb = (val) => val.toString(16).padStart(2, '0');
+        const a = padRgb(rgbVals[0]);
+        const r = padRgb(rgbVals[1]);
+        const g = padRgb(rgbVals[2]);
+        const b = padRgb(rgbVals[3]);
+        const hexStr = '#' + a + r + g + b;
+
         if (window.StatusBar) {
-            window.StatusBar.backgroundColorByHexString(value);
+            window.StatusBar.backgroundColorByHexString(hexStr);
         } else {
-            exec(null, null, 'SystemBarPlugin', 'setStatusBarBackgroundColor', [value]);
+            exec(null, null, 'SystemBarPlugin', 'setStatusBarBackgroundColor', rgbVals);
         }
     }
 });

framework/src/org/apache/cordova/SystemBarPlugin.java

@@ -89,8 +89,7 @@ public boolean execute(String action, JSONArray args, CallbackContext callbackCo
             boolean visible = args.getBoolean(0);
             cordova.getActivity().runOnUiThread(() -> setStatusBarVisible(visible));
         } else if ("setStatusBarBackgroundColor".equals(action)) {
-            String bgColor = args.getString(0);
-            cordova.getActivity().runOnUiThread(() -> setStatusBarBackgroundColor(bgColor));
+            cordova.getActivity().runOnUiThread(() -> setStatusBarBackgroundColor(args));
         } else {
             return false;
         }
@@ -120,17 +119,27 @@ private void setStatusBarVisible(final boolean visible) {
 
     /**
      * Allow the app to override the status bar background color from JS API.
-     * If the supplied string is invalid and fails to parse, it will silently ignore
+     * If the supplied ARGB is invalid or fails to parse, it will silently ignore
      * the change request.
      *
-     * @param colorPref hex string
+     * @param argbVals {A, R, G, B}
      */
-    private void setStatusBarBackgroundColor(final String colorPref) {
-        int parsedColor = parseColorFromString(colorPref);
-        if (parsedColor == INVALID_COLOR) return;
-
-        overrideStatusBarBackgroundColor = parsedColor;
-        updateStatusBar(overrideStatusBarBackgroundColor);
+    private void setStatusBarBackgroundColor(JSONArray argbVals) {
+        try {
+            int a = argbVals.getInt(0);
+            int r = argbVals.getInt(1);
+            int g = argbVals.getInt(2);
+            int b = argbVals.getInt(3);
+            String hexColor = String.format("#%02X%02X%02X%02X", a, r, g, b);
+
+            int parsedColor = parseColorFromString(hexColor);
+            if (parsedColor == INVALID_COLOR) return;
+
+            overrideStatusBarBackgroundColor = parsedColor;
+            updateStatusBar(overrideStatusBarBackgroundColor);
+        } catch (JSONException e) {
+            // Silently skip
+        }
     }
 
     /**