File tree Expand file tree Collapse file tree 1 file changed +6
-3
lines changed Expand file tree Collapse file tree 1 file changed +6
-3
lines changed Original file line number Diff line number Diff line change @@ -248,6 +248,7 @@ impl DataTypeMap {
248
248
}
249
249
250
250
/// Maps a `ScalarValue` to an Arrow `DataType`
251
+ /// TODO: Why not just use `ScalarValue::data_type`?
251
252
pub fn map_from_scalar_to_arrow ( scalar_val : & ScalarValue ) -> Result < DataType , PyErr > {
252
253
match scalar_val {
253
254
ScalarValue :: Boolean ( _) => Ok ( DataType :: Boolean ) ,
@@ -326,9 +327,11 @@ impl DataTypeMap {
326
327
ScalarValue :: Union ( _, _, _) => Err ( py_datafusion_err ( DataFusionError :: NotImplemented (
327
328
"ScalarValue::LargeList" . to_string ( ) ,
328
329
) ) ) ,
329
- ScalarValue :: Utf8View ( _) => todo ! ( ) ,
330
- ScalarValue :: BinaryView ( _) => todo ! ( ) ,
331
- ScalarValue :: Map ( _) => todo ! ( ) ,
330
+ ScalarValue :: Utf8View ( _) => Ok ( DataType :: Utf8View ) ,
331
+ ScalarValue :: BinaryView ( _) => Ok ( DataType :: BinaryView ) ,
332
+ ScalarValue :: Map ( _) => Err ( py_datafusion_err ( DataFusionError :: NotImplemented (
333
+ "ScalarValue::Map" . to_string ( ) ,
334
+ ) ) ) ,
332
335
}
333
336
}
334
337
}
You can’t perform that action at this time.
0 commit comments