Open text data type modifiers in all dialects

Author: yoavcloud

src/dialect/mod.rs

@@ -1451,16 +1451,6 @@ pub trait Dialect: Debug + Any {
         false
     }
 
-    /// Returns true if the dialect supports parenthesized modifiers for the `TEXT` data type.
-    ///
-    /// Example:
-    /// ```sql
-    /// SELECT col::TEXT(16777216)
-    /// ```
-    fn supports_text_type_modifiers(&self) -> bool {
-        false
-    }
-
     /// Returns true if the dialect supports the `INTERVAL` data type with [Postgres]-style options.
     ///
     /// Examples:

src/dialect/snowflake.rs

@@ -235,11 +235,6 @@ impl Dialect for SnowflakeDialect {
         true
     }
 
-    /// See [doc](https://docs.snowflake.com/en/sql-reference/data-types-text)
-    fn supports_text_type_modifiers(&self) -> bool {
-        true
-    }
-
     /// See [doc](https://docs.snowflake.com/en/sql-reference/constructs/from)
     fn supports_parens_around_table_factor(&self) -> bool {
         true

src/parser/mod.rs

@@ -12556,15 +12556,11 @@ impl<'a> Parser<'a> {
                     Ok(DataType::FixedString(character_length))
                 }
                 Keyword::TEXT => {
-                    if dialect.supports_text_type_modifiers() {
-                        if let Some(modifiers) = self.parse_optional_type_modifiers()? {
-                            Ok(DataType::Custom(
-                                ObjectName::from(vec![Ident::new("TEXT")]),
-                                modifiers,
-                            ))
-                        } else {
-                            Ok(DataType::Text)
-                        }
+                    if let Some(modifiers) = self.parse_optional_type_modifiers()? {
+                        Ok(DataType::Custom(
+                            ObjectName::from(vec![Ident::new("TEXT")]),
+                            modifiers,
+                        ))
                     } else {
                         Ok(DataType::Text)
                     }

tests/sqlparser_common.rs

@@ -6588,13 +6588,12 @@ fn interval_disallow_interval_expr_double_colon() {
 
 #[test]
 fn parse_text_type_modifier_double_colon_cast() {
-    let dialects = all_dialects_where(|d| d.supports_text_type_modifiers());
-    let expr = dialects.verified_expr("_ID::TEXT(16777216)");
+    let expr = verified_expr("ID::TEXT(16777216)");
     assert_eq!(
         expr,
         Expr::Cast {
             kind: CastKind::DoubleColon,
-            expr: Box::new(Expr::Identifier(Ident::new("_ID"))),
+            expr: Box::new(Expr::Identifier(Ident::new("ID"))),
             data_type: DataType::Custom(
                 ObjectName::from(vec![Ident::new("TEXT")]),
                 vec!["16777216".to_string()]