Merge pull request #19 from fmguerreiro/fix/matview-with-no-data

feat(parser): parse WITH [NO] DATA on CREATE MATERIALIZED VIEW

Author: fmguerreiro

.worktrees/fix-pr-2307-ci

@@ -18,7 +18,7 @@
 [package]
 name = "pgmold-sqlparser"
 description = "Fork of sqlparser with additional PostgreSQL features (PARTITION OF, SECURITY DEFINER/INVOKER, SET params, EXCLUDE, TEXT SEARCH, AGGREGATE, FOREIGN TABLE/FDW, PUBLICATION, SUBSCRIPTION, ALTER DOMAIN/TRIGGER/EXTENSION, CAST, CONVERSION, LANGUAGE, RULE, STATISTICS, ACCESS METHOD, EVENT TRIGGER, TRANSFORM, SECURITY LABEL, USER MAPPING, TABLESPACE)"
-version = "0.60.10"
+version = "0.60.11"
 authors = ["Filipe Guerreiro <filipe.m.guerreiro@gmail.com>"]
 homepage = "https://github.com/fmguerreiro/datafusion-sqlparser-rs"
 documentation = "https://docs.rs/pgmold-sqlparser/"

Cargo.toml

@@ -4364,6 +4364,11 @@ pub struct CreateView {
     pub to: Option<ObjectName>,
     /// MySQL: Optional parameters for the view algorithm, definer, and security context
     pub params: Option<CreateViewParams>,
+    /// PostgreSQL: `WITH [NO] DATA` clause on materialized views.
+    /// `None` means the clause was absent; `Some(true)` means `WITH DATA`;
+    /// `Some(false)` means `WITH NO DATA`.
+    /// <https://www.postgresql.org/docs/current/sql-creatematerializedview.html>
+    pub with_data: Option<bool>,
 }
 
 impl fmt::Display for CreateView {
@@ -4430,6 +4435,11 @@ impl fmt::Display for CreateView {
         if self.with_no_schema_binding {
             write!(f, " WITH NO SCHEMA BINDING")?;
         }
+        match self.with_data {
+            Some(true) => write!(f, " WITH DATA")?,
+            Some(false) => write!(f, " WITH NO DATA")?,
+            None => {}
+        }
         Ok(())
     }
 }

src/ast/ddl.rs

@@ -6645,6 +6645,20 @@ impl<'a> Parser<'a> {
                 Keyword::BINDING,
             ]);
 
+        // PostgreSQL: optional WITH [NO] DATA clause on materialized views.
+        // pg_dump emits this clause; parse it so corpus schemas round-trip cleanly.
+        let with_data = if materialized && self.parse_keyword(Keyword::WITH) {
+            if self.parse_keyword(Keyword::NO) {
+                self.expect_keyword_is(Keyword::DATA)?;
+                Some(false)
+            } else {
+                self.expect_keyword_is(Keyword::DATA)?;
+                Some(true)
+            }
+        } else {
+            None
+        };
+
         Ok(CreateView {
             or_alter,
             name,
@@ -6663,6 +6677,7 @@ impl<'a> Parser<'a> {
             to,
             params: create_view_params,
             name_before_not_exists,
+            with_data,
         })
     }