Skip to content

Serializing custom TableSource implementations fails #16749

New issue
New issue
Open
#16750
Open
Serializing custom TableSource implementations fails#16749
#16750
Labels
bugSomething isn't working
@colinmarc

Description

@colinmarc
colinmarc
opened on Jul 11, 2025

Describe the bug

LogicalExtensionCodec allows providing a custom serialization strategy for a TableProvider, but the calling code always expects a DefaultTableSource to unwrap:

datafusion/datafusion/proto/src/logical_plan/mod.rs

Line 1004 in 8d7b11b

let provider = source_as_provider(source)?;

Which calls source_as_provider:

datafusion/datafusion/catalog/src/default_table_source.rs

Lines 99 to 110 in 8d7b11b

pub fn source_as_provider(
source: &Arc<dyn TableSource>,
) -> datafusion_common::Result<Arc<dyn TableProvider>> {
match source
.as_ref()
.as_any()
.downcast_ref::<DefaultTableSource>()
{
Some(source) => Ok(Arc::clone(&source.table_provider)),
_ => internal_err!("TableSource was not DefaultTableSource"),
}
}

It would be better if LogicalExtensionCodec had encode_table_source instead of encode_table_provider.

To Reproduce

No response

Expected behavior

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions