-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
good first issueGood for newcomersGood for newcomers
Description
@findepi noted that AsyncScalarUDFImpl::invoke_async_with_args
is inconsistent with ScalarUDFImpl::invoke_async_with_args
Here is AsyncScalarUDFImpl::invoke_async_with_args
:
datafusion/datafusion/expr/src/async_udf.rs
Lines 49 to 54 in dbc03fa
async fn invoke_async_with_args( | |
&self, | |
args: ScalarFunctionArgs, | |
option: &ConfigOptions, | |
) -> Result<ArrayRef>; | |
} |
ScalarUDFImpl::invoke_with_args
datafusion/datafusion/expr/src/udf.rs
Line 557 in d553ffd
fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue>; |
Specifically I think they should both return a ColumnarValue
Why ArrayRef instead of ColumnarValue?
Is this inconsistency warranted?
Originally posted by @findepi in #16846 (comment)
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers