Skip to content

Make AsyncScalarUDFImpl::invoke_async_with_args consistent with ScalarUDFImpl::invoke_with_args  #16896

@alamb

Description

@alamb

@findepi noted that AsyncScalarUDFImpl::invoke_async_with_args is inconsistent with ScalarUDFImpl::invoke_async_with_args

Here is AsyncScalarUDFImpl::invoke_async_with_args:

async fn invoke_async_with_args(
&self,
args: ScalarFunctionArgs,
option: &ConfigOptions,
) -> Result<ArrayRef>;
}

ScalarUDFImpl::invoke_with_args

fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue>;

Specifically I think they should both return a ColumnarValue

Why ArrayRef instead of ColumnarValue?
Is this inconsistency warranted?

Originally posted by @findepi in #16846 (comment)

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions