From 2a601167e023614176d022079cfad2392262aaeb Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sat, 2 Aug 2025 06:44:13 -0400 Subject: [PATCH 1/6] Add nodejs and npm to dec container --- .devcontainer/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 51111543b4bb..caa07844941f 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -7,5 +7,5 @@ RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \ # Add protoc # https://datafusion.apache.org/contributor-guide/development_environment.html#protoc-installation RUN apt-get update \ - && apt-get install -y --no-install-recommends protobuf-compiler libprotobuf-dev \ + && apt-get install -y --no-install-recommends protobuf-compiler libprotobuf-dev npm nodejs\ && rm -rf /var/lib/apt/lists/* From f77a268b270c40b3a8efbbb9624cfad12203b556 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sat, 2 Aug 2025 06:51:49 -0400 Subject: [PATCH 2/6] Add prettier --- .devcontainer/Dockerfile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index caa07844941f..4f733b781045 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -4,8 +4,9 @@ RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \ # Remove imagemagick due to https://security-tracker.debian.org/tracker/CVE-2019-10131 && apt-get purge -y imagemagick imagemagick-6-common -# Add protoc +# Add protoc, npm, prettier # https://datafusion.apache.org/contributor-guide/development_environment.html#protoc-installation RUN apt-get update \ && apt-get install -y --no-install-recommends protobuf-compiler libprotobuf-dev npm nodejs\ + && npm install -y prettier@2.7.1 && rm -rf /var/lib/apt/lists/* From a3ae3a5b71e1c9758591f3c27c61f06072b04f00 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sat, 2 Aug 2025 06:55:13 -0400 Subject: [PATCH 3/6] correct version --- .devcontainer/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 4f733b781045..ccfe7627d071 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -8,5 +8,5 @@ RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \ # https://datafusion.apache.org/contributor-guide/development_environment.html#protoc-installation RUN apt-get update \ && apt-get install -y --no-install-recommends protobuf-compiler libprotobuf-dev npm nodejs\ - && npm install -y prettier@2.7.1 + && npm install -y prettier@2.3.2 && rm -rf /var/lib/apt/lists/* From 2f76b6d5eb5d7f1cb8652a8c0f28819c4fbcec90 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sat, 2 Aug 2025 06:58:14 -0400 Subject: [PATCH 4/6] fix --- .devcontainer/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index ccfe7627d071..4a975fdb8662 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -8,5 +8,5 @@ RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \ # https://datafusion.apache.org/contributor-guide/development_environment.html#protoc-installation RUN apt-get update \ && apt-get install -y --no-install-recommends protobuf-compiler libprotobuf-dev npm nodejs\ - && npm install -y prettier@2.3.2 + && npm install -y prettier@2.3.2\ && rm -rf /var/lib/apt/lists/* From dde1f6dae59b9e00654d2e91c998c15ddc7e50af Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sat, 2 Aug 2025 07:17:15 -0400 Subject: [PATCH 5/6] more hacking --- .devcontainer/Dockerfile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 4a975fdb8662..3a06026536f1 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -4,6 +4,10 @@ RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \ # Remove imagemagick due to https://security-tracker.debian.org/tracker/CVE-2019-10131 && apt-get purge -y imagemagick imagemagick-6-common +# setup the containers WORKDIR so npm install works +# https://stackoverflow.com/questions/57534295/npm-err-tracker-idealtree-already-exists-while-creating-the-docker-image-for +WORKDIR /root + # Add protoc, npm, prettier # https://datafusion.apache.org/contributor-guide/development_environment.html#protoc-installation RUN apt-get update \ From edc221c644d6c1ee4f08fd3881f163fa62551057 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sat, 2 Aug 2025 11:47:58 -0400 Subject: [PATCH 6/6] update npm --- .devcontainer/Dockerfile | 1 - 1 file changed, 1 deletion(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 3a06026536f1..49aacd118e19 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -12,5 +12,4 @@ WORKDIR /root # https://datafusion.apache.org/contributor-guide/development_environment.html#protoc-installation RUN apt-get update \ && apt-get install -y --no-install-recommends protobuf-compiler libprotobuf-dev npm nodejs\ - && npm install -y prettier@2.3.2\ && rm -rf /var/lib/apt/lists/*