HBASE-30073 Test fixes for some flappers and a reproducible error (#8057) (#8082)

Signed-off by: Charles Connell <cconnell@apache.org>

Author: haridsv

hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseJupiterExtension.java

@@ -84,7 +84,7 @@ public class HBaseJupiterExtension implements InvocationInterceptor, BeforeAllCa
 
   private static final Map<String, Duration> TAG_TO_TIMEOUT =
     ImmutableMap.of(SmallTests.TAG, Duration.ofMinutes(3), MediumTests.TAG, Duration.ofMinutes(6),
-      LargeTests.TAG, Duration.ofMinutes(13), IntegrationTests.TAG, Duration.ZERO);
+      LargeTests.TAG, Duration.ofMinutes(20), IntegrationTests.TAG, Duration.ZERO);
 
   private static final String EXECUTOR = "executor";
 

hbase-compression/pom.xml

@@ -45,6 +45,11 @@
       <artifactId>hbase-resource-bundle</artifactId>
       <optional>true</optional>
     </dependency>
+    <dependency>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-api</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <build>

hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java

@@ -631,6 +631,10 @@ protected List<RegionPlan> balanceTable(TableName tableName,
       currentCost / sumMultiplier, functionCost(), computedMaxSteps);
 
     final String initFunctionTotalCosts = totalCostsPerFunc();
+    long searchStartTime = EnvironmentEdgeManager.currentTime();
+    // Budget maxRunningTime for the stochastic walk only; initialization (cluster costs, etc.)
+    // can be substantial on busy hosts and must not consume the search deadline.
+    cluster.setStopRequestedAt(searchStartTime + maxRunningTime);
     // Perform a stochastic walk to see if we can get a good fit.
     long step;
     Map<Class<? extends CandidateGenerator>, Long> generatorToStepCount = new HashMap<>();

hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java

@@ -489,7 +489,13 @@ private void createSubDirAndSystemProperty(String propertyName, Path parent, Str
 
     String sysValue = System.getProperty(propertyName);
 
-    if (sysValue != null) {
+    // Check if directory sharing should be disabled for this test.
+    // Tests that run with high parallelism and don't need shared directories can set this
+    // to avoid race conditions where one test's tearDown() deletes directories another test
+    // is still using.
+    boolean disableSharing = conf.getBoolean("hbase.test.disable-directory-sharing", false);
+
+    if (sysValue != null && !disableSharing) {
       // There is already a value set. So we do nothing but hope
       // that there will be no conflicts
       LOG.info("System.getProperty(\"" + propertyName + "\") already set to: " + sysValue
@@ -502,7 +508,7 @@ private void createSubDirAndSystemProperty(String propertyName, Path parent, Str
       }
       conf.set(propertyName, sysValue);
     } else {
-      // Ok, it's not set, so we create it as a subdirectory
+      // Ok, it's not set (or sharing is disabled), so we create it as a subdirectory
       createSubDir(propertyName, parent, subDirName);
       System.setProperty(propertyName, conf.get(propertyName));
     }

hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java

@@ -77,7 +77,6 @@ public static void setUpBeforeClass() throws Exception {
     conf.setInt(HConstants.ZK_SESSION_TIMEOUT, 1000);
     conf.setClass(HConstants.HBASE_MASTER_LOADBALANCER_CLASS, MockLoadBalancer.class,
       LoadBalancer.class);
-    TEST_UTIL.startMiniDFSCluster(2);
   }
 
   @AfterAll

hbase-server/src/test/java/org/apache/hadoop/hbase/client/AbstractTestAsyncTableScan.java

@@ -46,6 +46,7 @@
 import java.util.stream.Stream;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.hbase.ConnectionRule;
+import org.apache.hadoop.hbase.HBaseConfiguration;
 import org.apache.hadoop.hbase.HBaseTestingUtility;
 import org.apache.hadoop.hbase.MatcherPredicate;
 import org.apache.hadoop.hbase.MiniClusterRule;
@@ -73,8 +74,21 @@
 public abstract class AbstractTestAsyncTableScan {
 
   protected static final OpenTelemetryClassRule OTEL_CLASS_RULE = OpenTelemetryClassRule.create();
-  protected static final MiniClusterRule MINI_CLUSTER_RULE = MiniClusterRule.newBuilder()
-    .setMiniClusterOption(StartMiniClusterOption.builder().numWorkers(3).build()).build();
+
+  private static Configuration createConfiguration() {
+    // Use HBaseConfiguration.create() instead of new Configuration() to properly load
+    // hbase-default.xml which contains required default values (e.g. for log cleaner plugins)
+    Configuration conf = HBaseConfiguration.create();
+    // Disable directory sharing to prevent race conditions when tests run in parallel.
+    // Each test instance gets its own isolated directories to avoid one test's tearDown()
+    // deleting directories another parallel test is still using.
+    conf.setBoolean("hbase.test.disable-directory-sharing", true);
+    return conf;
+  }
+
+  protected static final MiniClusterRule MINI_CLUSTER_RULE =
+    MiniClusterRule.newBuilder().setConfiguration(createConfiguration())
+      .setMiniClusterOption(StartMiniClusterOption.builder().numWorkers(3).build()).build();
 
   protected static final ConnectionRule CONN_RULE =
     ConnectionRule.createAsyncConnectionRule(MINI_CLUSTER_RULE::createAsyncConnection);