Skip to content

Commit 2d487fe

Browse files
authored
Maven Wrapper fix and java 21 update. #6637, #6711 (#6712)
* Update maven wrapper, fixes #6637 * Upgrade to java 21, fixes #6711
1 parent 2abee2f commit 2d487fe

File tree

28 files changed

+469
-2946
lines changed

28 files changed

+469
-2946
lines changed

.github/workflows/pr_build_code.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ jobs:
3434

3535
steps:
3636
- uses: actions/checkout@v2
37-
- name: Set up JDK 17
37+
- name: Set up JDK 21
3838
uses: actions/setup-java@v1
3939
with:
40-
java-version: 17
40+
java-version: 21
4141
- name: Cache Maven packages
4242
uses: actions/cache@v4
4343
with:

.github/workflows/pr_build_docs.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ jobs:
3232

3333
steps:
3434
- uses: actions/checkout@v2
35-
- name: Set up JDK 17
35+
- name: Set up JDK 21
3636
uses: actions/setup-java@v1
3737
with:
38-
java-version: 17
38+
java-version: 21
3939
- name: RAT Check
4040
run: mvn clean apache-rat:check

.mvn/wrapper/MavenWrapperDownloader.java

Lines changed: 0 additions & 114 deletions
This file was deleted.
Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,3 @@
1-
#
2-
# Licensed to the Apache Software Foundation (ASF) under one or more
3-
# contributor license agreements. See the NOTICE file distributed with
4-
# this work for additional information regarding copyright ownership.
5-
# The ASF licenses this file to You under the Apache License, Version 2.0
6-
# (the "License"); you may not use this file except in compliance with
7-
# the License. You may obtain a copy of the License at
8-
#
9-
# http://www.apache.org/licenses/LICENSE-2.0
10-
#
11-
# Unless required by applicable law or agreed to in writing, software
12-
# distributed under the License is distributed on an "AS IS" BASIS,
13-
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14-
# See the License for the specific language governing permissions and
15-
# limitations under the License.
16-
#
17-
#
18-
19-
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip
20-
wrapperUrl=https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar
1+
wrapperVersion=3.3.4
2+
distributionType=only-script
3+
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.12/apache-maven-3.9.12-bin.zip

Jenkinsfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
*/
1919

2020
def AGENT_LABEL = env.AGENT_LABEL ?: 'ubuntu'
21-
def JDK_NAME = env.JDK_NAME ?: 'jdk_17_latest'
21+
def JDK_NAME = env.JDK_NAME ?: 'jdk_21_latest'
2222
def MAVEN_NAME = env.MAVEN_NAME ?: 'maven_3_latest'
2323

2424
def MAVEN_PARAMS = "-T 2 -U -B -e -fae -V -Dmaven.compiler.fork=true -Dsurefire.rerunFailingTestsCount=2 -DSkipTestContainers=true"

Jenkinsfile.daily

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
*/
1919

2020
def AGENT_LABEL = env.AGENT_LABEL ?: 'ubuntu'
21-
def JDK_NAME = env.JDK_NAME ?: 'jdk_17_latest'
21+
def JDK_NAME = env.JDK_NAME ?: 'jdk_21_latest'
2222
def MAVEN_NAME = env.MAVEN_NAME ?: 'maven_3_latest'
2323

2424
def MAVEN_PARAMS = "-T 2 -U -B -e -fae -V -Dmaven.compiler.fork=true -Dsurefire.rerunFailingTestsCount=2 -DSkipTestContainers=true"

Jenkinsfile.hop-web-selenium

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
*/
1919

2020
def AGENT_LABEL = env.AGENT_LABEL ?: 'ubuntu'
21-
def JDK_NAME = env.JDK_NAME ?: 'jdk_17_latest'
21+
def JDK_NAME = env.JDK_NAME ?: 'jdk_21_latest'
2222
def MAVEN_NAME = env.MAVEN_NAME ?: 'maven_3_latest'
2323

2424
def MAVEN_PARAMS = "-T 2 -U -B -e -fae -V -Dmaven.compiler.fork=true -Dsurefire.rerunFailingTestsCount=2"

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,14 @@ the [Hop website](https://hop.apache.org) for more information on how to contrib
5151

5252
Required:
5353

54-
- [OpenJDK](https://openjdk.java.net/) Java 17 compiler. Make sure to update your JDK to the latest possible patch
54+
- [OpenJDK](https://openjdk.java.net/) Java 21 compiler. Make sure to update your JDK to the latest possible patch
5555
version.
5656

5757
Recommended:
5858

5959
- [Maven](http://maven.apache.org/) 3.6.3 or higher
6060

61-
Verify Maven Java version: (should be Java 17 to compile properly without skipping tests)
61+
Verify Maven Java version: (should be Java 21 to compile properly without skipping tests)
6262

6363
mvn -version
6464

@@ -84,11 +84,11 @@ You can download a source release [here](https://downloads.apache.org/hop/)
8484

8585
Required:
8686

87-
- [OpenJDK](https://openjdk.java.net/) Java 17 compiler or higher. Make sure to get the latest updates to support recent
87+
- [OpenJDK](https://openjdk.java.net/) Java 21 compiler or higher. Make sure to get the latest updates to support recent
8888
features like dark mode on the various platforms.
8989
- [Maven](http://maven.apache.org/) 3.6.3 or higher
9090

91-
Verify Maven Java version: (should be Java 17 to compile properly without skipping tests)
91+
Verify Maven Java version: (should be Java 21 to compile properly without skipping tests)
9292

9393
mvn -version
9494

docker/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ RUN addgroup -g ${HOP_GID} -S hop \
9494
&& adduser -u ${HOP_UID} -S -D -G hop hop \
9595
&& chmod 777 -R /tmp && chmod o+t -R /tmp \
9696
&& apk update \
97-
&& apk --no-cache add bash curl fontconfig msttcorefonts-installer openjdk17-jre procps \
97+
&& apk --no-cache add bash curl fontconfig msttcorefonts-installer openjdk21-jre procps \
9898
&& update-ms-fonts \
9999
&& fc-cache -f \
100100
&& rm -rf /var/cache/apk/* \

docker/dataflowTemplate.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# under the License.
1717
#
1818

19-
FROM gcr.io/dataflow-templates-base/java17-template-launcher-base
19+
FROM gcr.io/dataflow-templates-base/java21-template-launcher-base
2020

2121
ARG WORKDIR=/dataflow/template
2222
RUN mkdir -p ${WORKDIR}

0 commit comments

Comments
 (0)