fix: correct clang-tidy HeaderFilterRegex to match Posix ERE #310
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeaderFilterRegexis a whitelist to determine info of which header file will be reported by clang-tidy.Previous config
HeaderFilterRegex: '(?!_deps)(src|test|example)'can filterbuild/_deps/nlohmann_json-src, but it is an illegal syntax in clang-tidy's regex engine. It seems that clang-tidy doesn't support negative lookahead. Forgive me for using 'seems', I have only found too little information about clang-tidy's regex syntax. And in fact I still haven't figured out how it works. And there are also some bugs in clang-tidy, see llvm/llvm-project#138302.Clang-tidy 19 supports a new feature
ExcludeHeaderFilterRegexbut we use version 18 as default. So we can only find another way to filterbuild/_deps/nlohmann_json-src.