optimize: avoid using unstable API in ChannelEventHandlerIntegrationTest (#7518) (#7520)

Author: slievrly

changes/en-us/2.x.md

@@ -71,6 +71,7 @@ Add changes here for all PR submitted to the 2.x branch.
 - [[#7478](https://github.com/apache/incubator-seata/pull/7478)] metrics add retry status
 - [[#7483](https://github.com/apache/incubator-seata/pull/7483)] change the value of retryDeadThreshold to 70 seconds
 - [[#7488](https://github.com/apache/incubator-seata/pull/7488)] upgrade tomcat to 9.0.106
+- [[#7518](https://github.com/apache/incubator-seata/pull/7518)] avoid using unstable API in ChannelEventHandlerIntegrationTest
 
 ### security:
 

changes/zh-cn/2.x.md

@@ -69,6 +69,7 @@
 - [[#7466](https://github.com/apache/incubator-seata/pull/7466)] 在 issue 模板中添加贡献意向勾选框
 - [[#7478](https://github.com/apache/incubator-seata/pull/7478)] 增加处于重试状态的数据采集
 - [[#7483](https://github.com/apache/incubator-seata/pull/7483)] 将retryDeadThreshold改为70秒
+- [[#7518](https://github.com/apache/incubator-seata/pull/7518)] 避免在 ChannelEventHandlerIntegrationTest 中使用不稳定的 API
 
 
 ### security:

core/src/test/java/org/apache/seata/core/rpc/netty/ChannelEventHandlerIntegrationTest.java

@@ -23,15 +23,11 @@
 import io.netty.channel.ChannelInitializer;
 import io.netty.channel.ChannelPipeline;
 import io.netty.channel.EventLoopGroup;
-import io.netty.channel.SingleThreadEventLoop;
-import io.netty.channel.group.DefaultChannelGroup;
 import io.netty.channel.nio.NioEventLoopGroup;
 import io.netty.channel.socket.SocketChannel;
 import io.netty.channel.socket.nio.NioServerSocketChannel;
 import io.netty.channel.socket.nio.NioSocketChannel;
 import io.netty.handler.timeout.IdleStateHandler;
-import io.netty.util.concurrent.EventExecutor;
-import io.netty.util.concurrent.GlobalEventExecutor;
 import org.junit.jupiter.api.*;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.ArgumentCaptor;
@@ -41,7 +37,6 @@
 
 import java.net.InetSocketAddress;
 import java.net.SocketAddress;
-import java.util.Iterator;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 
@@ -198,17 +193,15 @@ void testChannelInactive() throws Exception {
     void testChannelInactiveByServer() throws Exception {
         connectClient();
 
-        DefaultChannelGroup serverChannels = new DefaultChannelGroup(GlobalEventExecutor.INSTANCE);
-        serverChannels.addAll(collectServerChannels(workerGroup));
-        Channel serverSideClientChannel = serverChannels.stream()
-                .filter(ch -> ch.isActive() && ch.remoteAddress() != null)
-                .findFirst()
-                .orElseThrow(() -> new AssertionError("Failed to find client channel on server side"));
+        // Simulate server-side behavior by performing shutdown operations in the event loop
+        clientChannel.eventLoop().execute(() -> {
+            // Simulate server-side disconnection
+            clientChannel.pipeline().fireChannelInactive();
+        });
 
-        serverSideClientChannel.close().sync();
         assertTrue(
                 channelInactiveLatch.await(TIMEOUT_SECONDS, TimeUnit.SECONDS),
-                "Channel inactive event was not detected on client side when server closed the connection");
+                "Channel inactive event was not detected on client side when connection was closed");
         verify(mockRemotingClient).onChannelInactive(any(Channel.class));
     }
 
@@ -257,27 +250,4 @@ protected void initChannel(SocketChannel ch) {
         clientChannel = future.channel();
         assertTrue(clientChannel.isActive());
     }
-
-    private DefaultChannelGroup collectServerChannels(EventLoopGroup workerGroup) throws InterruptedException {
-        DefaultChannelGroup channels = new DefaultChannelGroup(GlobalEventExecutor.INSTANCE);
-
-        for (EventExecutor executor : workerGroup) {
-            if (executor instanceof SingleThreadEventLoop) {
-                SingleThreadEventLoop eventLoop = (SingleThreadEventLoop) executor;
-
-                executor.submit(() -> {
-                            Iterator<Channel> it = eventLoop.registeredChannelsIterator();
-                            while (it.hasNext()) {
-                                Channel ch = it.next();
-                                if (ch.isActive() && ch instanceof SocketChannel) {
-                                    channels.add(ch);
-                                }
-                            }
-                            return null;
-                        })
-                        .sync();
-            }
-        }
-        return channels;
-    }
 }