Replacing unused variable suppress warning with _ (Part 2/5) (#15105)

---------

Signed-off-by: Ankit Jain <[email protected]>

Author: jainankitk

lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/SpatialFileQueryMaker.java

@@ -82,9 +82,7 @@ protected Query[] prepareQueries() throws Exception {
           i--; // skip
         }
       }
-    } catch (
-        @SuppressWarnings("unused")
-        NoMoreDataException e) {
+    } catch (NoMoreDataException _) {
       // all-done
     } finally {
       src.close();

lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/NewAnalyzerTask.java

@@ -79,9 +79,7 @@ public int doLogic() throws IOException {
             String coreClassName = "org.apache.lucene.analysis.core." + analyzerName;
             analyzer = createAnalyzer(coreClassName);
             analyzerName = coreClassName;
-          } catch (
-              @SuppressWarnings("unused")
-              ClassNotFoundException e) {
+          } catch (ClassNotFoundException _) {
             // If not a core analyzer, try the base analysis package
             analyzerName = "org.apache.lucene.analysis." + analyzerName;
             analyzer = createAnalyzer(analyzerName);

lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/TaskSequence.java

@@ -206,9 +206,7 @@ private int doSerialTasks() throws Exception {
               countsByTime[slot] += inc;
             }
             if (anyExhaustibleTasks) updateExhausted(task);
-          } catch (
-              @SuppressWarnings("unused")
-              NoMoreDataException e) {
+          } catch (NoMoreDataException _) {
             exhausted = true;
           }
         }
@@ -275,9 +273,7 @@ private int doSerialTasksWithRate() throws Exception {
           }
 
           if (anyExhaustibleTasks) updateExhausted(task);
-        } catch (
-            @SuppressWarnings("unused")
-            NoMoreDataException e) {
+        } catch (NoMoreDataException _) {
           exhausted = true;
         }
       }
@@ -319,9 +315,7 @@ public void run() {
           updateExhausted(task);
         }
         count += n;
-      } catch (
-          @SuppressWarnings("unused")
-          NoMoreDataException e) {
+      } catch (NoMoreDataException _) {
         exhausted = true;
       } catch (Exception e) {
         throw new RuntimeException(e);

lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/utils/Algorithm.java

@@ -308,9 +308,7 @@ private Class<?> taskClass(Config config, String taskName) throws ClassNotFoundE
     for (String pkg : taskPackages) {
       try {
         return Class.forName(pkg + '.' + taskName + "Task");
-      } catch (
-          @SuppressWarnings("unused")
-          ClassNotFoundException e) {
+      } catch (ClassNotFoundException _) {
         // failed in this package, might succeed in the next one...
       }
     }

lucene/benchmark/src/java/org/apache/lucene/benchmark/quality/QualityQuery.java

@@ -74,9 +74,7 @@ public int compareTo(QualityQuery other) {
       int n = Integer.parseInt(queryID);
       int nOther = Integer.parseInt(other.queryID);
       return n - nOther;
-    } catch (
-        @SuppressWarnings("unused")
-        NumberFormatException e) {
+    } catch (NumberFormatException _) {
       // fall back to string comparison
       return queryID.compareTo(other.queryID);
     }

lucene/benchmark/src/java/org/apache/lucene/benchmark/utils/ExtractWikipedia.java

@@ -96,9 +96,7 @@ public void extract() throws Exception {
             doc.get(DocMaker.DATE_FIELD),
             doc.get(DocMaker.BODY_FIELD));
       }
-    } catch (
-        @SuppressWarnings("unused")
-        NoMoreDataException e) {
+    } catch (NoMoreDataException _) {
       // continue
     }
     long finish = System.currentTimeMillis();

lucene/benchmark/src/test/org/apache/lucene/benchmark/byTask/feeds/TestTrecContentSource.java

@@ -424,9 +424,7 @@ public void testTrecFeedDirAllTypes() throws Exception {
             assertTrue("Should never get here!", false);
         }
       }
-    } catch (
-        @SuppressWarnings("unused")
-        NoMoreDataException e) {
+    } catch (NoMoreDataException _) {
       gotExpectedException = true;
     }
     assertTrue("Should have gotten NoMoreDataException!", gotExpectedException);

lucene/core/src/java/org/apache/lucene/analysis/TokenStream.java

@@ -111,9 +111,7 @@ private boolean assertFinal() {
               || Modifier.isFinal(clazz.getMethod("incrementToken").getModifiers())
           : "TokenStream implementation classes or at least their incrementToken() implementation must be final";
       return true;
-    } catch (
-        @SuppressWarnings("unused")
-        NoSuchMethodException nsme) {
+    } catch (NoSuchMethodException _) {
       return false;
     }
   }

lucene/core/src/java/org/apache/lucene/codecs/lucene103/blocktree/IntersectTermsEnum.java

@@ -364,9 +364,7 @@ public Throwable fillInStackTrace() {
   public BytesRef next() throws IOException {
     try {
       return _next();
-    } catch (
-        @SuppressWarnings("unused")
-        NoMoreTermsException eoi) {
+    } catch (NoMoreTermsException _) {
       // Provoke NPE if we are (illegally!) called again:
       currentFrame = null;
       return null;

lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsWriter.java

@@ -497,9 +497,7 @@ public void finish(int numDocs) throws IOException {
     boolean v = true;
     try {
       v = Boolean.parseBoolean(System.getProperty(BULK_MERGE_ENABLED_SYSPROP, "true"));
-    } catch (
-        @SuppressWarnings("unused")
-        SecurityException ignored) {
+    } catch (SecurityException _) {
     }
     BULK_MERGE_ENABLED = v;
   }