nimble/ll: Use const for addr parameters

In general we should pass any addr parameter to function as const since
we only rarely need to modify its contents and the address itself may
point to our device address which we never want to be able to modify
from outsied ble_ll_addr by mistake...

Author: andrzej-kaczmarek

nimble/controller/include/controller/ble_ll.h

@@ -540,7 +540,7 @@ int ble_ll_addr_subtype(const uint8_t *addr, uint8_t addr_type);
 int ble_ll_addr_is_id(uint8_t *addr, uint8_t addr_type);
 
 /* Is 'addr' our device address? 'addr_type' is public (0) or random (!=0) */
-int ble_ll_is_our_devaddr(uint8_t *addr, int addr_type);
+int ble_ll_is_our_devaddr(const uint8_t* addr, int addr_type);
 
 /* Get identity address 'addr_type' is public (0) or random (!=0) */
 uint8_t *ble_ll_get_our_devaddr(uint8_t addr_type);

nimble/controller/include/controller/ble_ll_conn.h

@@ -483,7 +483,7 @@ void ble_ll_conn_send_connect_req_cancel(void);
 /* Signal connection created via CONNECT_IND */
 void ble_ll_conn_created_on_legacy(struct os_mbuf *rxpdu,
                                    struct ble_ll_scan_addr_data *addrd,
-                                   uint8_t *targeta);
+                                   const uint8_t* targeta);
 #if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
 /* Signal connection created via AUX_CONNECT_REQ */
 void ble_ll_conn_created_on_aux(struct os_mbuf *rxpdu,

nimble/controller/include/controller/ble_ll_resolv.h

@@ -90,8 +90,8 @@ void ble_ll_resolv_list_reset(void);
 void ble_ll_resolv_get_priv_addr(struct ble_ll_resolv_entry *rl, int local,
                                  uint8_t *addr);
 
-void ble_ll_resolv_set_peer_rpa(int index, uint8_t *rpa);
-void ble_ll_resolv_set_local_rpa(int index, uint8_t *rpa);
+void ble_ll_resolv_set_peer_rpa(int index, const uint8_t* rpa);
+void ble_ll_resolv_set_local_rpa(int index, const uint8_t* rpa);
 
 /* Generate a resolvable private address. */
 int ble_ll_resolv_gen_rpa(uint8_t *addr, uint8_t addr_type, uint8_t *rpa,

nimble/controller/include/controller/ble_ll_scan.h

@@ -108,9 +108,9 @@ struct ble_ll_scan_vs_config {
 };
 
 struct ble_ll_scan_addr_data {
-    uint8_t *adva;
-    uint8_t *targeta;
-    uint8_t *adv_addr;
+    const uint8_t *adva;
+    const uint8_t *targeta;
+    const uint8_t *adv_addr;
     uint8_t adva_type : 1;
     uint8_t targeta_type : 1;
     uint8_t adv_addr_type : 1;
@@ -223,7 +223,7 @@ ble_ll_scan_initiator_start(struct ble_ll_conn_sm *connsm, uint8_t ext,
 struct ble_ll_scan_pdu_data *ble_ll_scan_get_pdu_data(void);
 
 /* Called to set the resolvable private address of the last connected peer */
-void ble_ll_scan_set_peer_rpa(uint8_t *rpa);
+void ble_ll_scan_set_peer_rpa(const uint8_t* rpa);
 
 /* Returns peer RPA of last connection made */
 uint8_t *ble_ll_scan_get_peer_rpa(void);
@@ -256,14 +256,14 @@ uint8_t ble_ll_scan_get_filt_dups(void);
 uint8_t ble_ll_scan_backoff_kick(void);
 void ble_ll_scan_backoff_update(int success);
 
-int ble_ll_scan_dup_check_ext(uint8_t addr_type, uint8_t *addr, bool has_aux,
-                              uint16_t adi);
-int ble_ll_scan_dup_update_ext(uint8_t addr_type, uint8_t *addr, bool has_aux,
-                               uint16_t adi);
-int ble_ll_scan_have_rxd_scan_rsp(uint8_t *addr, uint8_t txadd, uint8_t ext_adv,
-                                  uint16_t adi);
-void ble_ll_scan_add_scan_rsp_adv(uint8_t *addr, uint8_t txadd, uint8_t ext_adv,
-                                  uint16_t adi);
+int ble_ll_scan_dup_check_ext(uint8_t addr_type, const uint8_t* addr,
+                              bool has_aux, uint16_t adi);
+int ble_ll_scan_dup_update_ext(uint8_t addr_type, const uint8_t* addr,
+                               bool has_aux, uint16_t adi);
+int ble_ll_scan_have_rxd_scan_rsp(const uint8_t* addr, uint8_t txadd,
+                                  uint8_t ext_adv, uint16_t adi);
+void ble_ll_scan_add_scan_rsp_adv(const uint8_t* addr, uint8_t txadd,
+                                  uint8_t ext_adv, uint16_t adi);
 
 struct ble_ll_scan_sm *ble_ll_scan_sm_get(void);
 

nimble/controller/include/controller/ble_ll_whitelist.h

@@ -43,7 +43,7 @@ void ble_ll_whitelist_enable(void);
 void ble_ll_whitelist_disable(void);
 
 /* Boolean function returning true if address matches a whitelist entry */
-int ble_ll_whitelist_match(uint8_t *addr, uint8_t addr_type, int is_ident);
+int ble_ll_whitelist_match(const uint8_t* addr, uint8_t addr_type, int is_ident);
 
 #ifdef __cplusplus
 }

nimble/controller/src/ble_ll.c

@@ -717,7 +717,7 @@ ble_ll_set_random_addr(const uint8_t *cmdbuf, uint8_t len, bool hci_adv_ext)
  * @return int 0: not our device address. 1: is our device address
  */
 int
-ble_ll_is_our_devaddr(uint8_t *addr, int addr_type)
+ble_ll_is_our_devaddr(const uint8_t* addr, int addr_type)
 {
     int rc;
     uint8_t *our_addr;

nimble/controller/src/ble_ll_conn.c

@@ -3304,7 +3304,8 @@ ble_ll_conn_send_connect_req_cancel(void)
 
 static void
 ble_ll_conn_central_start(uint8_t phy, uint8_t csa,
-                          struct ble_ll_scan_addr_data *addrd, uint8_t *targeta)
+                          struct ble_ll_scan_addr_data *addrd,
+                          const uint8_t *targeta)
 {
     struct ble_ll_conn_sm *connsm;
 
@@ -3340,7 +3341,7 @@ ble_ll_conn_central_start(uint8_t phy, uint8_t csa,
 void
 ble_ll_conn_created_on_legacy(struct os_mbuf *rxpdu,
                               struct ble_ll_scan_addr_data *addrd,
-                              uint8_t *targeta)
+                              const uint8_t* targeta)
 {
     uint8_t *rxbuf;
     uint8_t csa;

nimble/controller/src/ble_ll_resolv.c

@@ -621,7 +621,7 @@ ble_ll_resolv_get_priv_addr(struct ble_ll_resolv_entry *rl, int local,
 }
 
 void
-ble_ll_resolv_set_peer_rpa(int index, uint8_t *rpa)
+ble_ll_resolv_set_peer_rpa(int index, const uint8_t* rpa)
 {
     os_sr_t sr;
     struct ble_ll_resolv_entry *rl;
@@ -633,7 +633,7 @@ ble_ll_resolv_set_peer_rpa(int index, uint8_t *rpa)
 }
 
 void
-ble_ll_resolv_set_local_rpa(int index, uint8_t *rpa)
+ble_ll_resolv_set_local_rpa(int index, const uint8_t* rpa)
 {
     os_sr_t sr;
     struct ble_ll_resolv_entry *rl;

nimble/controller/src/ble_ll_scan.c

@@ -391,7 +391,7 @@ ble_ll_scan_halt(void)
  * @return int 0: have not received a scan response; 1 otherwise.
  */
 int
-ble_ll_scan_have_rxd_scan_rsp(uint8_t *addr, uint8_t txadd,
+ble_ll_scan_have_rxd_scan_rsp(const uint8_t* addr, uint8_t txadd,
                               uint8_t ext_adv, uint16_t adi)
 {
     uint8_t num_advs;
@@ -435,7 +435,7 @@ ble_ll_scan_have_rxd_scan_rsp(uint8_t *addr, uint8_t txadd,
 
 #if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
 void
-ble_ll_scan_add_scan_rsp_adv(uint8_t *addr, uint8_t txadd,
+ble_ll_scan_add_scan_rsp_adv(const uint8_t* addr, uint8_t txadd,
                              uint8_t ext_adv, uint16_t adi)
 {
     uint8_t num_advs;
@@ -1800,7 +1800,8 @@ ble_ll_scan_dup_new(void)
 }
 
 static int
-ble_ll_scan_dup_check_legacy(uint8_t addr_type, uint8_t *addr, uint8_t pdu_type)
+ble_ll_scan_dup_check_legacy(uint8_t addr_type, const uint8_t* addr,
+                             uint8_t pdu_type)
 {
     struct ble_ll_scan_dup_entry *e;
     uint8_t type;
@@ -1840,7 +1841,7 @@ ble_ll_scan_dup_check_legacy(uint8_t addr_type, uint8_t *addr, uint8_t pdu_type)
 
 #if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
 int
-ble_ll_scan_dup_check_ext(uint8_t addr_type, uint8_t *addr, bool has_aux,
+ble_ll_scan_dup_check_ext(uint8_t addr_type, const uint8_t* addr, bool has_aux,
                           uint16_t adi)
 {
     struct ble_ll_scan_dup_entry *e;
@@ -1889,7 +1890,7 @@ ble_ll_scan_dup_check_ext(uint8_t addr_type, uint8_t *addr, bool has_aux,
 }
 
 int
-ble_ll_scan_dup_update_ext(uint8_t addr_type, uint8_t *addr, bool has_aux,
+ble_ll_scan_dup_update_ext(uint8_t addr_type, const uint8_t* addr, bool has_aux,
                            uint16_t adi)
 {
     struct ble_ll_scan_dup_entry *e;
@@ -2010,7 +2011,7 @@ ble_ll_scan_rx_pkt_in(uint8_t ptype, struct os_mbuf *om, struct ble_mbuf_hdr *hd
     struct ble_mbuf_hdr_rxinfo *rxinfo = &hdr->rxinfo;
 #endif
 #if MYNEWT_VAL(BLE_LL_ROLE_CENTRAL)
-    uint8_t *targeta;
+    const uint8_t *targeta;
 #endif
     struct ble_ll_scan_sm *scansm;
     struct ble_ll_scan_addr_data addrd;
@@ -2710,7 +2711,7 @@ ble_ll_scan_get_local_rpa(void)
  * @param rpa
  */
 void
-ble_ll_scan_set_peer_rpa(uint8_t *rpa)
+ble_ll_scan_set_peer_rpa(const uint8_t *rpa)
 {
     struct ble_ll_scan_sm *scansm;
 

nimble/controller/src/ble_ll_whitelist.c

@@ -164,7 +164,7 @@ ble_ll_whitelist_search(const uint8_t *addr, uint8_t addr_type)
  * @return int
  */
 int
-ble_ll_whitelist_match(uint8_t *addr, uint8_t addr_type, int is_ident)
+ble_ll_whitelist_match(const uint8_t* addr, uint8_t addr_type, int is_ident)
 {
     int rc;
 #if (BLE_USES_HW_WHITELIST == 1)