Skip to content

Commit 415a31c

Browse files
committed
CatalogEntity: internal endpoint not considered
Setting an S3 internal endpoint doesn't work, because the property's not carried over from the OpenAPI model type into `AwsStorageConfigInfo`.
1 parent 7960c39 commit 415a31c

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ private StorageConfigInfo getStorageInfo(Map<String, String> internalProperties)
141141
.setEndpoint(awsConfig.getEndpoint())
142142
.setStsEndpoint(awsConfig.getStsEndpoint())
143143
.setPathStyleAccess(awsConfig.getPathStyleAccess())
144+
.setEndpointInternal(awsConfig.getEndpointInternal())
144145
.build();
145146
}
146147
if (configInfo instanceof AzureStorageConfigurationInfo) {

runtime/service/src/intTest/java/org/apache/polaris/service/it/RestCatalogMinIOSpecialIT.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,15 @@ public void testInternalEndpoints() throws IOException {
230230
Optional.of(endpoint),
231231
false,
232232
Optional.of(endpoint))) {
233+
StorageConfigInfo storageConfig =
234+
managementApi.getCatalog(catalogName).getStorageConfigInfo();
235+
assertThat((AwsStorageConfigInfo) storageConfig)
236+
.extracting(
237+
AwsStorageConfigInfo::getEndpoint,
238+
AwsStorageConfigInfo::getStsEndpoint,
239+
AwsStorageConfigInfo::getEndpointInternal,
240+
AwsStorageConfigInfo::getPathStyleAccess)
241+
.containsExactly("http://s3.example.com", endpoint, endpoint, false);
233242
LoadTableResponse loadTableResponse = doTestCreateTable(restCatalog);
234243
assertThat(loadTableResponse.config()).containsEntry("s3.endpoint", "http://s3.example.com");
235244
}

0 commit comments

Comments
 (0)