Skip to content

Commit 99d0867

Browse files
Address review comments
1 parent bffb367 commit 99d0867

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

extensions/federation/hive/src/main/java/org/apache/polaris/extensions/federation/hive/HiveFederatedCatalogFactory.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,18 @@ public Catalog createCatalog(
5454
// Unlike Hadoop, HiveCatalog does not require us to create a Configuration object, the iceberg
5555
// rest library find the default configuration by reading hive-site.xml in the classpath
5656
// (including HADOOP_CONF_DIR classpath).
57+
58+
// TODO: In the future, we could support multiple HiveCatalog instances based on polaris/catalog
59+
// properties.
60+
// A brief set of setps involved (and the options):
61+
// 1. Create a configuration without default properties.
62+
// `Configuration conf = new Configuration(boolean loadDefaults=false);`
63+
// 2a. Specify the hive-site.xml file path in the configuration.
64+
// `conf.addResource(new Path(hiveSiteXmlPath));`
65+
// 2b. Specify individual properties in the configuration.
66+
// `conf.set(property, value);`
67+
// In this case, Polaris could support federating to multiple LDAP based Hive metastores.
68+
// Kerberos is still not suitable because it ties a single identities to the server.
5769
HiveCatalog hiveCatalog = new HiveCatalog();
5870
hiveCatalog.initialize(
5971
warehouse, connectionConfigInfoDpo.asIcebergCatalogProperties(userSecretsManager));

0 commit comments

Comments
 (0)